From: Leon Romanovsky <leon@kernel.org>
To: Yunsheng Lin <linyunsheng@huawei.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v1 2/2] net: remove __skb_frag_set_page()
Date: Tue, 9 May 2023 16:41:23 +0300 [thread overview]
Message-ID: <20230509134123.GM38143@unreal> (raw)
In-Reply-To: <20230509114337.21005-3-linyunsheng@huawei.com>
On Tue, May 09, 2023 at 07:43:37PM +0800, Yunsheng Lin wrote:
> The remaining users calling __skb_frag_set_page() with
> page being NULL seems to be doing defensive programming,
> as shinfo->nr_frags is already decremented, so remove
> them.
>
> Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
> ---
> RFC: remove a local variable as pointed out by Simon.
> ---
> drivers/net/ethernet/broadcom/bnx2.c | 1 -
> drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5 +----
> include/linux/skbuff.h | 12 ------------
> 3 files changed, 1 insertion(+), 17 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2023-05-09 13:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 11:43 [PATCH net-next v1 0/2] introduce skb_frag_fill_page_desc() Yunsheng Lin
2023-05-09 11:43 ` [PATCH net-next v1 1/2] net: introduce and use skb_frag_fill_page_desc() Yunsheng Lin
2023-05-09 13:43 ` Leon Romanovsky
2023-05-09 11:43 ` [PATCH net-next v1 2/2] net: remove __skb_frag_set_page() Yunsheng Lin
2023-05-09 13:41 ` Leon Romanovsky [this message]
2023-05-10 1:00 ` [PATCH net-next v1 0/2] introduce skb_frag_fill_page_desc() Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2023-05-09 11:46 [PATCH net-next v1 2/2] net: remove __skb_frag_set_page() Yunsheng Lin
2023-05-09 18:53 ` Michael Chan
2023-05-09 23:49 ` Jesse Brandeburg
2023-05-10 8:16 ` Simon Horman
2023-05-09 11:42 [PATCH net-next v1 0/2] introduce skb_frag_fill_page_desc() Yunsheng Lin
2023-05-09 11:42 ` [PATCH net-next v1 2/2] net: remove __skb_frag_set_page() Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230509134123.GM38143@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).