From: Daniel Machon <daniel.machon@microchip.com>
To: <netdev@vger.kernel.org>
Cc: <dsahern@kernel.org>, <stephen@networkplumber.org>,
<petrm@nvidia.com>, <UNGLinuxDriver@microchip.com>,
<daniel.machon@microchip.com>
Subject: [PATCH iproute2-next v3 03/12] dcb: app: move colon printing out of callbacks
Date: Tue, 6 Jun 2023 09:19:38 +0200 [thread overview]
Message-ID: <20230510-dcb-rewr-v3-3-60a766f72e61@microchip.com> (raw)
In-Reply-To: <20230510-dcb-rewr-v3-0-60a766f72e61@microchip.com>
In preparation for changing the prototype of dcb_app_print_filtered(),
move the colon printing out of the callbacks, and into
dcb_app_print_filtered().
Signed-off-by: Daniel Machon <daniel.machon@microchip.com>
---
dcb/dcb_app.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/dcb/dcb_app.c b/dcb/dcb_app.c
index 644c37d36ffb..ed7930ae7b37 100644
--- a/dcb/dcb_app.c
+++ b/dcb/dcb_app.c
@@ -405,12 +405,12 @@ static bool dcb_app_is_port(const struct dcb_app *app)
static int dcb_app_print_key_dec(__u16 protocol)
{
- return print_uint(PRINT_ANY, NULL, "%u:", protocol);
+ return print_uint(PRINT_ANY, NULL, "%u", protocol);
}
static int dcb_app_print_key_hex(__u16 protocol)
{
- return print_uint(PRINT_ANY, NULL, "%x:", protocol);
+ return print_uint(PRINT_ANY, NULL, "%x", protocol);
}
static int dcb_app_print_key_dscp(__u16 protocol)
@@ -419,17 +419,17 @@ static int dcb_app_print_key_dscp(__u16 protocol)
if (!is_json_context() && name != NULL)
- return print_string(PRINT_FP, NULL, "%s:", name);
- return print_uint(PRINT_ANY, NULL, "%u:", protocol);
+ return print_string(PRINT_FP, NULL, "%s", name);
+ return print_uint(PRINT_ANY, NULL, "%u", protocol);
}
static int dcb_app_print_key_pcp(__u16 protocol)
{
/* Print in numerical form, if protocol value is out-of-range */
if (protocol > DCB_APP_PCP_MAX)
- return print_uint(PRINT_ANY, NULL, "%u:", protocol);
+ return print_uint(PRINT_ANY, NULL, "%u", protocol);
- return print_string(PRINT_ANY, NULL, "%s:", pcp_names[protocol]);
+ return print_string(PRINT_ANY, NULL, "%s", pcp_names[protocol]);
}
static void dcb_app_print_filtered(const struct dcb_app_table *tab,
@@ -454,7 +454,7 @@ static void dcb_app_print_filtered(const struct dcb_app_table *tab,
open_json_array(PRINT_JSON, NULL);
print_key(app->protocol);
- print_uint(PRINT_ANY, NULL, "%u ", app->priority);
+ print_uint(PRINT_ANY, NULL, ":%u ", app->priority);
close_json_array(PRINT_JSON, NULL);
}
--
2.34.1
next prev parent reply other threads:[~2023-06-06 7:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 7:19 [PATCH iproute2-next v3 00/12] Introduce new dcb-rewr subcommand Daniel Machon
2023-06-06 7:19 ` [PATCH iproute2-next v3 01/12] dcb: app: add new dcbnl attribute field Daniel Machon
2023-06-06 15:00 ` Petr Machata
2023-06-06 7:19 ` [PATCH iproute2-next v3 02/12] dcb: app: replace occurrences of %d with %u for printing unsigned int Daniel Machon
2023-06-06 9:29 ` Petr Machata
2023-06-06 7:19 ` Daniel Machon [this message]
2023-06-06 9:32 ` [PATCH iproute2-next v3 03/12] dcb: app: move colon printing out of callbacks Petr Machata
2023-06-06 7:19 ` [PATCH iproute2-next v3 04/12] dcb: app: rename dcb_app_print_key_*() functions Daniel Machon
2023-06-06 9:34 ` Petr Machata
2023-06-06 7:19 ` [PATCH iproute2-next v3 05/12] dcb: app: modify dcb_app_print_filtered() for dcb-rewr reuse Daniel Machon
2023-06-06 14:08 ` Petr Machata
2023-06-06 7:19 ` [PATCH iproute2-next v3 06/12] dcb: app: modify dcb_app_table_remove_replaced() " Daniel Machon
2023-06-06 13:10 ` Petr Machata
2023-06-06 7:19 ` [PATCH iproute2-next v3 07/12] dcb: app: expose functions required by dcb-rewr Daniel Machon
2023-06-06 13:11 ` Petr Machata
2023-06-06 7:19 ` [PATCH iproute2-next v3 08/12] dcb: rewr: add new dcb-rewr subcommand Daniel Machon
2023-06-06 13:17 ` Petr Machata
2023-06-06 7:19 ` [PATCH iproute2-next v3 09/12] dcb: rewr: add symbol for max DSCP value Daniel Machon
2023-06-06 13:14 ` Petr Machata
2023-06-06 7:19 ` [PATCH iproute2-next v3 10/12] man: dcb-rewr: add new manpage for dcb-rewr Daniel Machon
2023-06-06 7:19 ` [PATCH iproute2-next v3 11/12] man: dcb: add additional references under 'SEE ALSO' Daniel Machon
2023-06-06 7:19 ` [PATCH iproute2-next v3 12/12] man: dcb-app: clean up a few mistakes Daniel Machon
2023-06-09 21:50 ` [PATCH iproute2-next v3 00/12] Introduce new dcb-rewr subcommand patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230510-dcb-rewr-v3-3-60a766f72e61@microchip.com \
--to=daniel.machon@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=petrm@nvidia.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).