From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87F7F1773B for ; Thu, 11 May 2023 06:23:56 +0000 (UTC) Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3A6BCCA; Wed, 10 May 2023 23:23:55 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 511618109; Thu, 11 May 2023 06:23:54 +0000 (UTC) Date: Thu, 11 May 2023 09:23:53 +0300 From: Tony Lindgren To: Judith Mendez Cc: linux-can@vger.kernel.org, Chandrasekar Ramakrishnan , Wolfgang Grandegger , Marc Kleine-Budde , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Schuyler Patton , devicetree@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Oliver Hartkopp , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 2/2] can: m_can: Add hrtimer to generate software interrupt Message-ID: <20230511062353.GE14287@atomide.com> References: <20230510202952.27111-1-jm@ti.com> <20230510202952.27111-3-jm@ti.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230510202952.27111-3-jm@ti.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Hi, * Judith Mendez [230510 20:31]: > Add an hrtimer to MCAN class device. Each MCAN will have its own > hrtimer instantiated if there is no hardware interrupt found and > poll-interval property is defined in device tree M_CAN node. > > The hrtimer will generate a software interrupt every 1 ms. In > hrtimer callback, we check if there is a transaction pending by > reading a register, then process by calling the isr if there is. So what about system suspend, do you need to do something to ensure the timer does not happen to run while suspending? Regards, Tony