From: Stephen Hemminger <stephen@networkplumber.org>
To: Simon Horman <simon.horman@corigine.com>
Cc: Bilal Khan <bilalkhanrecovered@gmail.com>,
majordomo@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] Fix grammar in ip-rule(8) man page
Date: Thu, 11 May 2023 08:50:09 -0700 [thread overview]
Message-ID: <20230511085009.72b9da9e@hermes.local> (raw)
In-Reply-To: <ZFyyK4Cvcn//yZdV@corigine.com>
On Thu, 11 May 2023 11:15:23 +0200
Simon Horman <simon.horman@corigine.com> wrote:
> On Mon, May 08, 2023 at 01:05:02PM +0500, Bilal Khan wrote:
> > Hey there,
> >
> > I have identified a small grammatical error in the ip-rule(8) man
> > page, and have created a patch to fix it. The current first line of
> > the DESCRIPTION section reads:
> >
> > > ip rule manipulates rules in the routing policy database control the route selection algorithm.
> >
> > This sentence contains a grammatical error, as "control" should either
> > be changed to "that controls" (to apply to "database") or "to control"
> > (to apply to "manipulates"). I have updated the sentence to read:
> >
> > > ip rule manipulates rules in the routing policy database that controls the route selection algorithm.
> >
> > This change improves the readability and clarity of the ip-rule(8) man
> > page and makes it easier for users to understand how to use the IP
> > rule command.
> >
> > I have attached the patch file by the name
> > "0001-fixed-the-grammar-in-ip-rule-8-man-page.patch" to this email and
> > would appreciate any feedback or suggestions for improvement.
> >
> > Thank you!
>
> FWIIW, I'm not sure that an attachment is the right way to submit patches.
> It's more usual to use something like git send-email or b4 to send
> basically what is in your attachment.
>
> I'm sure Stephen will provide guidance if he'd like things done a different
> way.
Applied and did small fixups. Novices get more leeway in initial patch submissions.
The main requirements are that it correct, applies clean, and has required DCO.
next prev parent reply other threads:[~2023-05-11 15:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 8:05 [PATCH] Fix grammar in ip-rule(8) man page Bilal Khan
2023-05-11 9:15 ` Simon Horman
2023-05-11 15:50 ` Stephen Hemminger [this message]
2023-05-12 8:15 ` Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2023-04-27 6:41 Bilal Khan
2023-04-27 15:52 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230511085009.72b9da9e@hermes.local \
--to=stephen@networkplumber.org \
--cc=bilalkhanrecovered@gmail.com \
--cc=majordomo@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).