From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47E6FD2E4 for ; Mon, 15 May 2023 19:56:27 +0000 (UTC) Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DEE6E727 for ; Mon, 15 May 2023 12:56:21 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-965f7bdab6bso2339082066b.3 for ; Mon, 15 May 2023 12:56:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684180580; x=1686772580; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=C+XyNMlAETg+dR3Oy03ffSYzFpJWsWFCxJlmwho5nuY=; b=CYZSny1QI7fCwdUCHviYVtHoqUKOzpK+e2NFy1X/SbXEWI75v7qaSOzixaKdj2wkIT DpwtHIkI1ILrC56vo/+shvobpuXyPiVMDR8K9CagTBIUftXKl9Wube1A1KUWW5ZtdO7f fl4e3xiRh/2fAiKFCM/XX5WDPJuI2xcWcj7njNLLtvagqTVEAkrKQHI9MJ+3980b5nnL XQNtZ+kMnAo7/nlLLVaZ6uxoeyY+MgpR0qYdbbqGTHccFNUen3Ovlw9iNDrmgqfy5Q9u kG3SlfBcDodIvlOE1AykUooxhqDFoTkUxi5z6JgQqID3ttOY8LUZgoaxMx8WXrN3B6pQ DgOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684180580; x=1686772580; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C+XyNMlAETg+dR3Oy03ffSYzFpJWsWFCxJlmwho5nuY=; b=Wd/U00kRijER3ek5wOQycnqmrXu+mCtWUcAQ5kc4OepXd/W40lAqjl1lI2jBUyeN7v AFz2qP88B+silJJ+aVOJlWVQNf7sFhskv2QzvUzSB5QGrcrFAIX4Dvb8wI77jwvDTSF1 VYi/4G7ph9TFo2KoFgq/9ZnV0VmNsx5YAXd3+Llh+oD0jNItqmM5kC1ed9u+dFfOBmOi z296S/6x27LZ55OyC+jC8fxshhD/Y48T6CdqTnB+dRadYYMMNkNVm6RSrqi/fsmeJ4m+ hlwMfjSfJ1mLqxSFlQCIxHtOXMbytBJOBL+58RqHW9VG2r0WoswILpQ1xTw4GzQkWnTH rZyA== X-Gm-Message-State: AC+VfDzcCwir48a167sNLDuHXRWOiW93DP4yoNn+5IhvwZeA8h/blsn1 StuniTbGPc6uGE9UfJKRkFA= X-Google-Smtp-Source: ACHHUZ5Kze+PqMpF282DHjtxjRicRfGuHPl9XdDUyiPnJ8JCMhXoquCk8nP+oGKjyTsyVtdTzZG57Q== X-Received: by 2002:a17:907:2da9:b0:94f:247d:44d2 with SMTP id gt41-20020a1709072da900b0094f247d44d2mr32695380ejc.5.1684180579593; Mon, 15 May 2023 12:56:19 -0700 (PDT) Received: from skbuf ([188.27.184.189]) by smtp.gmail.com with ESMTPSA id s1-20020a1709070b2100b0096a16761ab4sm8570364ejl.144.2023.05.15.12.56.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 May 2023 12:56:19 -0700 (PDT) Date: Mon, 15 May 2023 22:56:16 +0300 From: Vladimir Oltean To: "Russell King (Oracle)" Cc: Andrew Lunn , AngeloGioacchino Del Regno , Daniel Machon , "David S. Miller" , Eric Dumazet , Felix Fietkau , Florian Fainelli , Heiner Kallweit , Horatiu Vultur , Ioana Ciornei , Jakub Kicinski , John Crispin , Jose Abreu , Lars Povlsen , Lorenzo Bianconi , Marcin Wojtas , Mark Lee , Matthias Brugger , Maxime Chevallier , Paolo Abeni , Sean Wang , Steen Hegelund , Taras Chornyi , Thomas Petazzoni , UNGLinuxDriver@microchip.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org Subject: Re: [PATCH RFC] Providing a helper for PCS inband negotiation Message-ID: <20230515195616.uwg62f7hw47mktfu@skbuf> References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Hello, On Mon, May 15, 2023 at 01:22:50PM +0100, Russell King (Oracle) wrote: > 1. Should 10GBASE-KR be included in the SGMII et.al. case in the code? > Any other interface modes that should be there? Obviously, > PHYLINK_PCS_NEG_NONE is not correct for 10GBASE-KR since it does use > inband AN. Does it make sense for the user to disable inband AN for > 10GBASE-KR? If so, maybe it should be under the 1000base-X case. What physical process (reference to IEEE 802.3 clause is fine) would be controlled by the phylink_pcs_neg_mode() function for the so-called 10GBASE-KR phy-mode?