netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mateusz Palczewski <mateusz.palczewski@intel.com>
To: j.vosburgh@gmail.com, andy@greyhouse.net, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	dbanerje@akamai.com, netdev@vger.kernel.org
Cc: Mateusz Palczewski <mateusz.palczewski@intel.com>
Subject: [PATCH iwl-net  v1 0/2] Fix for bond 802.3ad mode with VFs
Date: Tue, 16 May 2023 09:44:45 -0400	[thread overview]
Message-ID: <20230516134447.193511-1-mateusz.palczewski@intel.com> (raw)

Bond 802.3ad mode with PFs works fine.

Problem appears when one or both of the nodes contains VFs.
Let's assume there is setup with 2 hosts, on both there are 2 PFs with each one with 1 VFs.
Bond(802.3ad)--|--VFs(two VFs)--Switch(with lacp enabled)--VFs-Bond(802.3ad)
In this particular scenario, there are 2 problems:

1. VFs needs some more time than PFs to set the link up, bonding drivers checks link only once, without any delay.
This caused issues with setting up bonding link. Fixed by adding small delay loop which checks link state.
2. Only master link works properly. Slave link cannot negotiate connection. This happens because permanent hw address
is used for creating lacpdu packets, not current address. Fixed by using current hw address to create lacpdu packet.

Sebastian Basierski (2):
  drivers/net/bonding/bond_3ad: Use updated MAC address for lacpdu
    packets
  drivers/net/bonding: Added some delay while checking for VFs link

 drivers/net/bonding/bond_3ad.c  |  4 ++--
 drivers/net/bonding/bond_main.c | 14 +++++++++++++-
 2 files changed, 15 insertions(+), 3 deletions(-)

-- 
2.31.1


             reply	other threads:[~2023-05-16 13:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-16 13:44 Mateusz Palczewski [this message]
2023-05-16 13:44 ` [PATCH iwl-net v1 1/2] drivers/net/bonding/bond_3ad: Use updated MAC address for lacpdu packets Mateusz Palczewski
2023-05-16 15:02   ` Jay Vosburgh
2023-05-16 13:44 ` [PATCH iwl-net v1 2/2] drivers/net/bonding: Added some delay while checking for VFs link Mateusz Palczewski
2023-05-16 15:15   ` Jay Vosburgh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230516134447.193511-1-mateusz.palczewski@intel.com \
    --to=mateusz.palczewski@intel.com \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=dbanerje@akamai.com \
    --cc=edumazet@google.com \
    --cc=j.vosburgh@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).