netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Tariq Toukan <ttoukan.linux@gmail.com>
Cc: Tariq Toukan <tariqt@nvidia.com>,
	netdev@vger.kernel.org, drort@nvidia.com, samiram@nvidia.com,
	Gal Pressman <gal@nvidia.com>
Subject: Re: [RFC / RFT net 0/7] tls: rx: strp: fix inline crypto offload
Date: Tue, 16 May 2023 18:52:00 -0700	[thread overview]
Message-ID: <20230516185201.740afa55@kernel.org> (raw)
In-Reply-To: <939fd42c-d451-0927-abd8-877c867958bb@gmail.com>

On Tue, 16 May 2023 15:27:51 +0300 Tariq Toukan wrote:
> Here's an updated testing status:
> 
> 1. Reported issue is resolved.
> 2. All device-offload TLS RX/TX tests passed, except for the one issue 
> below.
> 
> Nothing indicates that this issue is new or related directly to your 
> fixes series. It might have been there for some time, hiding behind the 
> existing bugs.
> 
> Issue description:
> TlsDecryptError / TlsEncryptError increase when simultaneously creating 
> a bond interface.
> It doesn't happen each and every time. It reproduced several times in 
> different runs.
> The strange part is that the bond is created and attached to a different 
> interface, not the one running the TLS traffic!

Hm, that's pretty odd / scary. LMK if you hit a dead end, I hope 
it's not a memory corruption :S

> I think we should progress with the fixes:
> Tested-by: Shai Amiram <samiram@nvidia.com>

Thanks!

      reply	other threads:[~2023-05-17  1:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-11  1:20 [RFC / RFT net 0/7] tls: rx: strp: fix inline crypto offload Jakub Kicinski
2023-05-11  1:20 ` [RFC / RFT net 1/7] tls: rx: device: fix checking decryption status Jakub Kicinski
2023-05-11  1:20 ` [RFC / RFT net 2/7] tls: rx: strp: set the skb->len of detached / CoW'ed skbs Jakub Kicinski
2023-05-11 13:45   ` Simon Horman
2023-05-11  1:20 ` [RFC / RFT net 3/7] tls: rx: strp: force mixed decrypted records into copy mode Jakub Kicinski
2023-05-11  1:20 ` [RFC / RFT net 4/7] tls: rx: strp: fix determining record length in " Jakub Kicinski
2023-05-11  1:20 ` [RFC / RFT net 5/7] tls: rx: strp: factor out copying skb data Jakub Kicinski
2023-05-11  1:20 ` [RFC / RFT net 6/7] tls: rx: strp: preserve decryption status of skbs when needed Jakub Kicinski
2023-05-11  1:20 ` [RFC / RFT net 7/7] tls: rx: strp: don't use GFP_KERNEL in softirq context Jakub Kicinski
2023-05-11 10:17 ` [RFC / RFT net 0/7] tls: rx: strp: fix inline crypto offload Tariq Toukan
2023-05-16 12:27   ` Tariq Toukan
2023-05-17  1:52     ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230516185201.740afa55@kernel.org \
    --to=kuba@kernel.org \
    --cc=drort@nvidia.com \
    --cc=gal@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=samiram@nvidia.com \
    --cc=tariqt@nvidia.com \
    --cc=ttoukan.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).