From: Jakub Kicinski <kuba@kernel.org>
To: Angus Chen <angus.chen@jaguarmicro.com>
Cc: davem@davemloft.net, dsahern@kernel.org, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, idosch@idosch.org,
petrm@nvidia.com
Subject: Re: [PATCH v3] net: Remove low_thresh in ip defrag
Date: Tue, 16 May 2023 20:43:30 -0700 [thread overview]
Message-ID: <20230516204330.1443bc7c@kernel.org> (raw)
In-Reply-To: <20230517001820.1625-1-angus.chen@jaguarmicro.com>
On Wed, 17 May 2023 08:18:20 +0800 Angus Chen wrote:
> As low_thresh has no work in fragment reassembles,mark it to be unused.
> And Mark it deprecated in sysctl Document.
>
> Signed-off-by: Angus Chen <angus.chen@jaguarmicro.com>
We need to revert the old patch first, we can't remove the commit from
the git history because it would change all later hashes and break
rebasing.
Why are you renaming the member? Just add the comment and update the
documentation. You said you had a tested complaint, the tester will
only read the docs, right?
--
pw-bot: cr
next prev parent reply other threads:[~2023-05-17 3:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 0:18 [PATCH v3] net: Remove low_thresh in ip defrag Angus Chen
2023-05-17 3:43 ` Jakub Kicinski [this message]
2023-05-17 6:23 ` Angus Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230516204330.1443bc7c@kernel.org \
--to=kuba@kernel.org \
--cc=angus.chen@jaguarmicro.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=idosch@idosch.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).