From: Jakub Kicinski <kuba@kernel.org>
To: Taehee Yoo <ap420073@gmail.com>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
jiri@resnulli.us, j.vosburgh@gmail.com, andy@greyhouse.net,
netdev@vger.kernel.org, jarod@redhat.com, razor@blackwall.org,
simon.horman@corigine.com, wangyufen@huawei.com,
syzbot+60748c96cf5c6df8e581@syzkaller.appspotmail.com
Subject: Re: [PATCH net v2] net: fix stack overflow when LRO is disabled for virtual interfaces
Date: Fri, 19 May 2023 14:31:58 -0700 [thread overview]
Message-ID: <20230519143158.2de37be3@kernel.org> (raw)
In-Reply-To: <2ea192a8-b437-86e4-59b3-b4d57117aee1@gmail.com>
On Fri, 19 May 2023 15:25:12 +0900 Taehee Yoo wrote:
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 6b12d8a9d463..f051c293ffaa 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -9758,6 +9758,9 @@ int __netdev_update_features(struct net_device *dev)
> return -1;
> }
>
> + if (netif_is_bond_master(dev) || netif_is_team_master(dev))
> + dev->features = features;
> +
> /* some features must be disabled on lower devices when disabled
> * on an upper device (think: bonding master or bridge)
> */
>
> It fixes the stack overflow problem, but I'm not sure whether updating
> it before netdev_sync_lower_features() is safe or not.
Indeed, I don't think we can do this, udp_tunnel_drop_rx_info()
will get confused for example. Let me just apply the patch as is..
next prev parent reply other threads:[~2023-05-19 21:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 14:30 [PATCH net v2] net: fix stack overflow when LRO is disabled for virtual interfaces Taehee Yoo
2023-05-17 14:59 ` Eric Dumazet
2023-05-17 15:02 ` Nikolay Aleksandrov
2023-05-17 16:15 ` Jakub Kicinski
2023-05-17 17:28 ` Taehee Yoo
2023-05-17 18:45 ` Jakub Kicinski
2023-05-19 6:25 ` Taehee Yoo
2023-05-19 21:31 ` Jakub Kicinski [this message]
2023-05-20 5:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230519143158.2de37be3@kernel.org \
--to=kuba@kernel.org \
--cc=andy@greyhouse.net \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.vosburgh@gmail.com \
--cc=jarod@redhat.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=simon.horman@corigine.com \
--cc=syzbot+60748c96cf5c6df8e581@syzkaller.appspotmail.com \
--cc=wangyufen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).