From: Vladimir Oltean <olteanv@gmail.com>
To: "Arınç ÜNAL" <arinc.unal@arinc9.com>
Cc: Frank Wunderlich <frank-w@public-files.de>,
Felix Fietkau <nbd@nbd.name>, netdev <netdev@vger.kernel.org>,
erkin.bozoglu@xeront.com, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
John Crispin <john@phrozen.org>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Landen Chao <Landen.Chao@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
DENG Qingfang <dqfext@gmail.com>,
mithat.guner@xeront.com
Subject: Re: Choose a default DSA CPU port
Date: Sat, 20 May 2023 02:54:05 +0300 [thread overview]
Message-ID: <20230519235405.la4inpjqwk5wq7wx@skbuf> (raw)
In-Reply-To: <e140cec6-132c-0e3a-d48a-88cd176b9875@arinc9.com>
On Fri, May 19, 2023 at 12:00:17PM +0300, Arınç ÜNAL wrote:
> > mt7530_rmw(priv, MT753X_MFC, MT7530_CPU_EN | MT7530_CPU_PORT_MASK,
> > MT7530_CPU_PORT(0));
>
> If I understand correctly, the MT7530_CPU_EN bit here wouldn't be modified
> since it's not on the set parameter.
"mask": which bits are affected by the read-modify-write (rmw)
"set": which subset of "mask" remains set (the other subset, mask & ~set,
remains unset)
So no, MT7530_CPU_EN is not unmodified; it is quite cleared.
> On top of this, I believe we can completely get rid of the else case.
> The MT7530_CPU_PORT bits will be overwritten when there's an active
> CPU port so there's no need to clear them when there's no active CPU
> ports. MT7530_CPU_EN might as well stay set.
Sounds plausible.
next prev parent reply other threads:[~2023-05-19 23:54 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 20:44 Aw: Re: Choose a default DSA CPU port Frank Wunderlich
2023-02-24 21:08 ` Vladimir Oltean
2023-02-25 11:14 ` Aw: " Frank Wunderlich
2023-02-25 13:50 ` Frank Wunderlich
2023-02-25 16:11 ` Arınç ÜNAL
2023-02-25 19:56 ` Arınç ÜNAL
2023-02-26 12:12 ` Aw: " Frank Wunderlich
2023-02-28 9:54 ` Arınç ÜNAL
2023-02-28 11:58 ` Vladimir Oltean
2023-02-28 13:48 ` Frank Wunderlich
2023-02-28 22:56 ` Vladimir Oltean
2023-03-01 6:38 ` Frank Wunderlich
2023-03-01 12:37 ` Vladimir Oltean
2023-03-06 18:20 ` Aw: " Frank Wunderlich
2023-03-07 17:43 ` Vladimir Oltean
2023-04-13 18:09 ` Aw: " Frank Wunderlich
2023-04-13 21:30 ` Frank Wunderlich
2023-05-16 19:29 ` Arınç ÜNAL
2023-05-17 16:10 ` Vladimir Oltean
2023-05-17 16:14 ` Arınç ÜNAL
2023-05-17 16:16 ` Vladimir Oltean
2023-05-18 10:36 ` Arınç ÜNAL
2023-05-18 14:24 ` Vladimir Oltean
2023-05-19 9:00 ` Arınç ÜNAL
2023-05-19 23:54 ` Vladimir Oltean [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-02-18 17:07 Arınç ÜNAL
2023-02-18 20:17 ` Frank Wunderlich
2023-02-18 20:17 ` Florian Fainelli
2023-02-18 20:52 ` Vladimir Oltean
2023-02-19 7:35 ` Arınç ÜNAL
2023-02-19 9:49 ` Aw: " Frank Wunderlich
2023-02-21 0:27 ` Vladimir Oltean
2023-02-22 17:17 ` Aw: " Frank Wunderlich
2023-02-22 18:06 ` Vladimir Oltean
2023-02-22 18:08 ` Arınç ÜNAL
2023-02-22 19:34 ` Vladimir Oltean
2023-02-22 19:42 ` Arınç ÜNAL
2023-02-24 18:07 ` Aw: " Frank Wunderlich
2023-02-24 18:13 ` Vladimir Oltean
2023-02-24 18:16 ` Vladimir Oltean
2023-02-22 19:39 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230519235405.la4inpjqwk5wq7wx@skbuf \
--to=olteanv@gmail.com \
--cc=Landen.Chao@mediatek.com \
--cc=Mark-MC.Lee@mediatek.com \
--cc=andrew@lunn.ch \
--cc=arinc.unal@arinc9.com \
--cc=dqfext@gmail.com \
--cc=erkin.bozoglu@xeront.com \
--cc=f.fainelli@gmail.com \
--cc=frank-w@public-files.de \
--cc=john@phrozen.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mithat.guner@xeront.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox