From: Min-Hua Chen <minhuadotchen@gmail.com>
To: kuba@kernel.org
Cc: claudiu.beznea@microchip.com, davem@davemloft.net,
edumazet@google.com, linux-kernel@vger.kernel.org,
minhuadotchen@gmail.com, netdev@vger.kernel.org,
nicolas.ferre@microchip.com, pabeni@redhat.com
Subject: Re: [PATCH] net: macb: use correct __be32 and __be16 types
Date: Sat, 20 May 2023 10:00:35 +0800 [thread overview]
Message-ID: <20230520020035.216060-1-minhuadotchen@gmail.com> (raw)
In-Reply-To: <20230519152807.57d3f4c8@kernel.org>
>On Sat, 20 May 2023 06:19:39 +0800 Min-Hua Chen wrote:
>> This patch fixes the following sparse warnings. No functional changes.
>>
>> Use cpu_to_be16() and cpu_to_be32() to convert constants before comparing
>> them with __be16 type of psrc/pdst and __be32 type of ip4src/ip4dst.
>> Apply be16_to_cpu() in GEM_BFINS().
>
>same story as with your stmmac patch, the warning is a false positive
yes, the same story and let's discuss this in the stmmac thread [1].
[1] https://lore.kernel.org/lkml/20230520015527.215952-1-minhuadotchen@gmail.com/
thanks,
Min-Hua
prev parent reply other threads:[~2023-05-20 2:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 22:19 [PATCH] net: macb: use correct __be32 and __be16 types Min-Hua Chen
2023-05-19 22:28 ` Jakub Kicinski
2023-05-20 2:00 ` Min-Hua Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230520020035.216060-1-minhuadotchen@gmail.com \
--to=minhuadotchen@gmail.com \
--cc=claudiu.beznea@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).