From: Vladimir Oltean <olteanv@gmail.com>
To: David Epping <david.epping@missinglinkelectronics.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net 3/3] net: phy: mscc: enable VSC8501/2 RGMII RX clock
Date: Sun, 21 May 2023 16:12:26 +0300 [thread overview]
Message-ID: <20230521131226.bxk4g5gstprrvngp@skbuf> (raw)
In-Reply-To: <20230521123512.3kpy66sjnzj2chie@skbuf>
On Sun, May 21, 2023 at 03:35:12PM +0300, Vladimir Oltean wrote:
> Let's resolve that difference before the patches are merged, and write
> some correct comments.
>
> I agree that the datasheet is not clear, but I think that the RX_CLK
> output is enabled or not based on the strapping of the RCVRDCLK1 and
> RCVRDCLK2 pins. Coincidentally, these are also muxed with PHYADD1 and
> PHYADD2, so the default value of RX_CLK_DISABLE might depend on the
> PHY address (?!).
>
> What is your PHY address? Mine are 0x10 and 0x11 for the VSC8502 on my
> board.
>
> Not saying that the patch is wrong or that the resolution should be any
> different than it is. Just that it's clear we can't both be right, and
> my PHYs clearly work (re-tested just now).
>
> --
> pw-bot: changes-requested
Ah, no, I think the explanation is much simpler. I see the datasheet
mentions that "RX_CLK output disable" is a sticky bit, which means it
preserves its value across a reset.
In my case, it is the U-Boot driver which clears that setting, as part
of configuring RGMII delays.
https://source.denx.de/u-boot/u-boot/-/blob/master/drivers/net/phy/mscc.c#L1553
next prev parent reply other threads:[~2023-05-21 13:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-20 16:06 [PATCH net 0/3] net: phy: mscc: support VSC8501 David Epping
2023-05-20 16:06 ` [PATCH net 1/3] net: phy: mscc: add VSC8502 to MODULE_DEVICE_TABLE David Epping
2023-05-21 12:28 ` Vladimir Oltean
2023-05-20 16:06 ` [PATCH net 2/3] net: phy: mscc: add support for VSC8501 David Epping
2023-05-21 12:28 ` Vladimir Oltean
2023-05-20 16:06 ` [PATCH net 3/3] net: phy: mscc: enable VSC8501/2 RGMII RX clock David Epping
2023-05-21 12:35 ` Vladimir Oltean
2023-05-21 13:12 ` Vladimir Oltean [this message]
2023-05-21 16:08 ` David Epping
2023-05-21 13:43 ` Vladimir Oltean
2023-05-21 16:16 ` David Epping
2023-05-22 9:49 ` Vladimir Oltean
2023-05-22 9:54 ` Vladimir Oltean
2023-05-22 9:58 ` Vladimir Oltean
2023-05-22 14:00 ` David Epping
2023-05-22 14:42 ` Andrew Lunn
2023-05-22 15:11 ` Vladimir Oltean
2023-05-22 15:22 ` David Epping
2023-05-22 15:42 ` Vladimir Oltean
2023-05-21 17:59 ` Russell King (Oracle)
2023-05-22 13:48 ` David Epping
2023-05-21 13:33 ` [PATCH net 0/3] net: phy: mscc: support VSC8501 Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230521131226.bxk4g5gstprrvngp@skbuf \
--to=olteanv@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=david.epping@missinglinkelectronics.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox