From: Dario Binacchi <dario.binacchi@amarulasolutions.com>
To: netdev@vger.kernel.org
Cc: Michal Kubecek <mkubecek@suse.cz>,
Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>,
Dario Binacchi <dario.binacchi@amarulasolutions.com>
Subject: [PATCH ethtool 1/1] netlink/rss: move variable declaration out of the for loop
Date: Mon, 22 May 2023 18:17:10 +0200 [thread overview]
Message-ID: <20230522161710.1223759-1-dario.binacchi@amarulasolutions.com> (raw)
The patch fixes this compilation error:
netlink/rss.c: In function 'rss_reply_cb':
netlink/rss.c:166:3: error: 'for' loop initial declarations are only allowed in C99 mode
for (unsigned int i = 0; i < get_count(hash_funcs); i++) {
^
netlink/rss.c:166:3: note: use option -std=c99 or -std=gnu99 to compile your code
The project doesn't really need a C99 compiler, so let's move the variable
declaration outside the for loop.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
| 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--git a/netlink/rss.c b/netlink/rss.c
index 4ad6065ef698..a4a72e83fcf0 100644
--- a/netlink/rss.c
+++ b/netlink/rss.c
@@ -92,7 +92,7 @@ int rss_reply_cb(const struct nlmsghdr *nlhdr, void *data)
u8 *hkey = NULL;
bool silent;
int err_ret;
- int ret;
+ int i, ret;
silent = nlctx->is_dump || nlctx->is_monitor;
err_ret = silent ? MNL_CB_OK : MNL_CB_ERROR;
@@ -163,7 +163,7 @@ int rss_reply_cb(const struct nlmsghdr *nlhdr, void *data)
printf(" Operation not supported\n");
return 0;
}
- for (unsigned int i = 0; i < get_count(hash_funcs); i++) {
+ for (i = 0; i < get_count(hash_funcs); i++) {
printf(" %s: %s\n", get_string(hash_funcs, i),
(rss_hfunc & (1 << i)) ? "on" : "off");
}
--
2.32.0
next reply other threads:[~2023-05-22 16:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 16:17 Dario Binacchi [this message]
2023-05-22 16:37 ` [PATCH ethtool 1/1] netlink/rss: move variable declaration out of the for loop Kuniyuki Iwashima
2023-05-22 17:31 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230522161710.1223759-1-dario.binacchi@amarulasolutions.com \
--to=dario.binacchi@amarulasolutions.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=sudheer.mogilappagari@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).