From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB09A1640F
	for <netdev@vger.kernel.org>; Mon, 22 May 2023 17:18:55 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id B724EC433D2;
	Mon, 22 May 2023 17:18:54 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1684775935;
	bh=EJh81ERAwI1/1H4wTCD01XYRNVo9bAe3cDknyW2xH9Q=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=HsPYkJrrb00WygdzSGGqtiVtGAn1oMi/G1qP3qQyRL+2G1KOu5RW4jt6IHOfm9i7N
	 PrfqyAnCMp+22ZrwjcWXCJ1RFiY9t7uHVLT4C9f6Kz+IRe7v8w86HOIqsNMlYO1EZr
	 k04m5zjmtCQ5d+a85q0mGNnSWNQ6SZY8/WxP2Qa4NkmjMT7gtTBsorVK2QYELM011e
	 yH+Zrnn506u5EaEx2D2ORb2Cf7sSbPtJyClUkXYhMMjRtLw92ZOZZrqK1SV7psLc+V
	 YCY9iVotoOM3+pKePw5DtzW3KCipseBTX4vzdQHMOTTXwWH8jBiRJbznwphiY4nqFi
	 KRRt5+zB3YN3A==
From: SeongJae Park <sj@kernel.org>
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: sj@kernel.org,
	davem@davemloft.net,
	edumazet@google.com,
	kuba@kernel.org,
	linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org,
	nmanthey@amazon.de,
	pabeni@redhat.com,
	ptyadav@amazon.de,
	willemb@google.com
Subject: Re: [PATCH net] net: fix skb leak in __skb_tstamp_tx()
Date: Mon, 22 May 2023 17:18:53 +0000
Message-Id: <20230522171853.90173-1-sj@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20230522170430.56198-1-kuniyu@amazon.com>
References: 
Precedence: bulk
X-Mailing-List: netdev@vger.kernel.org
List-Id: <netdev.vger.kernel.org>
List-Subscribe: <mailto:netdev+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:netdev+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

On Mon, 22 May 2023 10:04:30 -0700 Kuniyuki Iwashima <kuniyu@amazon.com> wrote:

> From: SeongJae Park <sj@kernel.org>
> Date: Mon, 22 May 2023 16:55:05 +0000
> > Hi Pratyush,
> > 
> > On Mon, 22 May 2023 17:30:20 +0200 Pratyush Yadav <ptyadav@amazon.de> wrote:
> > 
> > > Commit 50749f2dd685 ("tcp/udp: Fix memleaks of sk and zerocopy skbs with
> > > TX timestamp.") added a call to skb_orphan_frags_rx() to fix leaks with
> > > zerocopy skbs. But it ended up adding a leak of its own. When
> > > skb_orphan_frags_rx() fails, the function just returns, leaking the skb
> > > it just cloned. Free it before returning.
> > > 
> > > This bug was discovered and resolved using Coverity Static Analysis
> > > Security Testing (SAST) by Synopsys, Inc.
> > > 
> > > Fixes: 50749f2dd685 ("tcp/udp: Fix memleaks of sk and zerocopy skbs with TX timestamp.")
> > 
> > Seems the commit has merged in several stable kernels.  Is the bug also
> > affecting those?  If so, would it be better to Cc stable@vger.kernel.org?
> 
> In netdev, we add 'net' in Subject for bugfix, then netdev maintainers
> send a pull request weekly, and stable maintainers backport the fixes to
> affected trees.
> 
> So we usually need not CC stable for netdev patches.

Thank you for the nice explanation!  Seems it is also well documented at
https://www.kernel.org/doc/html/v5.10/networking/netdev-FAQ.html#q-i-see-a-network-patch-and-i-think-it-should-be-backported-to-stable

However, I don't show the 'net' subject rule on the document.  Is it documented
somewhere else?


Thanks,
SJ

> 
> Thanks,
> Kuniyuki
>