From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95A3179D2 for ; Mon, 22 May 2023 17:23:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F9BFC433EF; Mon, 22 May 2023 17:23:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684776185; bh=MhBBT1nMzudYiViBFfN67N0fmenBHnlHJ/Vr666rN4M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YP47NsEXxkvHT0Iaww6+hxq4qgISGbD4M8slRTAeL0kPnHWc0kr+C6IR5wTDVJ/jF 7U7yJWltc6uktT7SdPKDQCErQG3AvIG1tZA5YHkg42+v+w6etsxPjY2QVhPtkyMAAo BHPdPbBoKXJKkATP4CDQsze1hisiHnnudCYG/5v6T4tRXn2nlGd7ktJKo+18QpYwLN LmkYcH/P4zNvnimJKWmCRHev/wACOOcrGell/xOYlLdRI2mLtkJhd83180tPU8PYOH DsB3qziz/B1RVX0h5vqyJDDUf+mklXp5ZxcYDqqr1UZnp8GOcmeXdLldHqjsOBsbUt /pofW4e5XZfWg== From: SeongJae Park To: SeongJae Park Cc: Kuniyuki Iwashima , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, nmanthey@amazon.de, pabeni@redhat.com, ptyadav@amazon.de, willemb@google.com Subject: Re: [PATCH net] net: fix skb leak in __skb_tstamp_tx() Date: Mon, 22 May 2023 17:23:02 +0000 Message-Id: <20230522172302.90235-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230522171853.90173-1-sj@kernel.org> References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Mon, 22 May 2023 17:18:53 +0000 SeongJae Park wrote: > On Mon, 22 May 2023 10:04:30 -0700 Kuniyuki Iwashima wrote: > > > From: SeongJae Park > > Date: Mon, 22 May 2023 16:55:05 +0000 > > > Hi Pratyush, > > > > > > On Mon, 22 May 2023 17:30:20 +0200 Pratyush Yadav wrote: > > > > > > > Commit 50749f2dd685 ("tcp/udp: Fix memleaks of sk and zerocopy skbs with > > > > TX timestamp.") added a call to skb_orphan_frags_rx() to fix leaks with > > > > zerocopy skbs. But it ended up adding a leak of its own. When > > > > skb_orphan_frags_rx() fails, the function just returns, leaking the skb > > > > it just cloned. Free it before returning. > > > > > > > > This bug was discovered and resolved using Coverity Static Analysis > > > > Security Testing (SAST) by Synopsys, Inc. > > > > > > > > Fixes: 50749f2dd685 ("tcp/udp: Fix memleaks of sk and zerocopy skbs with TX timestamp.") > > > > > > Seems the commit has merged in several stable kernels. Is the bug also > > > affecting those? If so, would it be better to Cc stable@vger.kernel.org? > > > > In netdev, we add 'net' in Subject for bugfix, then netdev maintainers > > send a pull request weekly, and stable maintainers backport the fixes to > > affected trees. > > > > So we usually need not CC stable for netdev patches. > > Thank you for the nice explanation! Seems it is also well documented at > https://www.kernel.org/doc/html/v5.10/networking/netdev-FAQ.html#q-i-see-a-network-patch-and-i-think-it-should-be-backported-to-stable > > However, I don't show the 'net' subject rule on the document. Is it documented > somewhere else? Seems I overlooked this: https://www.kernel.org/doc/html/v5.10/networking/netdev-FAQ.html#q-how-do-i-indicate-which-tree-net-vs-net-next-my-patch-should-be-in Thanks, SJ > > > Thanks, > SJ > > > > > Thanks, > > Kuniyuki > >