From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, pabeni@redhat.com, davem@davemloft.net,
edumazet@google.com, leon@kernel.org, saeedm@nvidia.com,
moshe@nvidia.com
Subject: Re: [patch net-next 0/3] devlink: small port_new/del() cleanup
Date: Tue, 23 May 2023 21:15:24 -0700 [thread overview]
Message-ID: <20230523211524.45f26a39@kernel.org> (raw)
In-Reply-To: <20230523123801.2007784-1-jiri@resnulli.us>
On Tue, 23 May 2023 14:37:58 +0200 Jiri Pirko wrote:
> This patchset cleans up couple of leftovers after recent devlink locking
> changes. Previously, both port_new/dev() commands were called without
> holding instance lock. Currently all devlink commands are called with
> instance lock held.
>
> The first patch just removes redundant port notification.
> The second one removes couple of outdated comments.
> The last patch changes port_dev() to have devlink_port pointer as an arg
> instead of port_index, which makes it similar to the rest of port
> related ops.
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2023-05-24 4:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 12:37 [patch net-next 0/3] devlink: small port_new/del() cleanup Jiri Pirko
2023-05-23 12:37 ` [patch net-next 1/3] devlink: remove duplicate port notification Jiri Pirko
2023-05-23 14:18 ` Simon Horman
2023-05-23 12:38 ` [patch net-next 2/3] devlink: remove no longer true locking comment from port_new/del() Jiri Pirko
2023-05-23 14:19 ` Simon Horman
2023-05-23 12:38 ` [patch net-next 3/3] devlink: pass devlink_port pointer to ops->port_del() instead of index Jiri Pirko
2023-05-23 14:19 ` Simon Horman
2023-05-24 4:15 ` Jakub Kicinski [this message]
2023-05-24 9:40 ` [patch net-next 0/3] devlink: small port_new/del() cleanup patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230523211524.45f26a39@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=leon@kernel.org \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).