netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
	Kurt Kanzenbach <kurt.kanzenbach@linutronix.de>,
	Paolo Abeni <pabeni@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC PATCH 1/2] net: Add sysfs files for threaded NAPI.
Date: Wed, 24 May 2023 08:55:07 -0700	[thread overview]
Message-ID: <20230524085507.3f38c758@kernel.org> (raw)
In-Reply-To: <20230524111259.1323415-2-bigeasy@linutronix.de>

On Wed, 24 May 2023 13:12:58 +0200 Sebastian Andrzej Siewior wrote:
> I've been looking into threaded NAPI. One awkward thing to do is
> to figure out the thread names, pids in order to adjust the thread
> priorities and SMP affinity.
> On PREEMPT_RT the NAPI thread is treated (by the user) the same way as
> the threaded interrupt which means a dedicate CPU affinity for the
> thread and a higher task priority to be favoured over other tasks on the
> CPU. Otherwise the NAPI thread can be preempted by other threads leading
> to delays in packet delivery.
> Having to run ps/ grep is awkward to get the PID right. It is not easy
> to match the interrupt since there is no obvious relation between the
> IRQ and the NAPI thread.
> NAPI threads are enabled often to mitigate the problems caused by a
> "pending" ksoftirqd (which has been mitigated recently by doing softiqrs
> regardless of ksoftirqd status). There is still the part that the NAPI
> thread does not use softnet_data::poll_list.

This needs to go to the netdev netlink family, not sysfs.
There's much more information about NAPI to expose and sysfs will
quickly start showing its limitations.

  parent reply	other threads:[~2023-05-24 15:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-24 11:12 [RFC PATCH 0/2] net: Add sysfs files for threaded NAPI Sebastian Andrzej Siewior
2023-05-24 11:12 ` [RFC PATCH 1/2] " Sebastian Andrzej Siewior
2023-05-24 13:38   ` Simon Horman
2023-05-24 13:53   ` Eric Dumazet
2023-05-24 14:41     ` Jiri Pirko
2023-05-24 15:52       ` Sebastian Andrzej Siewior
2023-05-24 14:43     ` Sebastian Andrzej Siewior
2023-05-24 15:55   ` Jakub Kicinski [this message]
2023-05-25  0:16     ` Nambiar, Amritha
2023-05-25  8:32   ` David Laight
2023-05-24 11:12 ` [RFC PATCH 2/2] intel/igb: Add a hint " Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230524085507.3f38c758@kernel.org \
    --to=kuba@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=edumazet@google.com \
    --cc=kurt.kanzenbach@linutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).