From: Oleksij Rempel <o.rempel@pengutronix.de>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Woojung Huh <woojung.huh@microchip.com>,
Andrew Lunn <andrew@lunn.ch>,
Arun Ramadoss <arun.ramadoss@microchip.com>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
UNGLinuxDriver@microchip.com, Eric Dumazet <edumazet@google.com>,
Vladimir Oltean <olteanv@gmail.com>,
kernel@pengutronix.de, Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next v1 1/5] net: dsa: microchip: improving error handling for 8-bit register RMW operations
Date: Wed, 24 May 2023 19:32:40 +0200 [thread overview]
Message-ID: <20230524173240.GA7074@pengutronix.de> (raw)
In-Reply-To: <ZG4FmSKeQzp6yG7z@shell.armlinux.org.uk>
On Wed, May 24, 2023 at 01:39:53PM +0100, Russell King (Oracle) wrote:
> On Wed, May 24, 2023 at 02:32:16PM +0200, Oleksij Rempel wrote:
> > This patch refines the error handling mechanism for 8-bit register
> > read-modify-write operations. In case of a failure, it now logs an error
> > message detailing the problematic offset. This enhancement aids in
> > debugging by providing more precise information when these operations
> > encounter issues.
> >
> > Furthermore, the ksz_prmw8() function has been updated to return error
> > values rather than void, enabling calling functions to appropriately
> > respond to errors.
>
> What happens when there is an error that affects the current and future
> accesses? Does this PHY driver then begin to flood the kernel log?
Yes. In the same way as it is done in all ksz_read*/ksz_write* helpers.
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2023-05-24 17:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 12:32 [PATCH net-next v1 0/5] Microchip DSA Driver Improvements Oleksij Rempel
2023-05-24 12:32 ` [PATCH net-next v1 1/5] net: dsa: microchip: improving error handling for 8-bit register RMW operations Oleksij Rempel
2023-05-24 12:39 ` Russell King (Oracle)
2023-05-24 17:32 ` Oleksij Rempel [this message]
2023-05-24 12:32 ` [PATCH net-next v1 2/5] net: dsa: microchip: add an enum for regmap widths Oleksij Rempel
2023-05-24 17:03 ` Andrew Lunn
2023-05-24 17:53 ` Oleksij Rempel
2023-05-24 12:32 ` [PATCH net-next v1 3/5] net: dsa: microchip: remove ksz_port:on variable Oleksij Rempel
2023-05-24 16:51 ` Andrew Lunn
2023-05-24 12:32 ` [PATCH net-next v1 4/5] net: dsa: microchip: ksz8: Prepare ksz8863_smi for regmap register access validation Oleksij Rempel
2023-05-24 16:59 ` Andrew Lunn
2023-05-24 17:56 ` Oleksij Rempel
2023-05-24 12:32 ` [PATCH net-next v1 5/5] net: dsa: microchip: Add register access control for KSZ8873 chip Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230524173240.GA7074@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=arun.ramadoss@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).