netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Osama Muhammad <osmtendev@gmail.com>
To: krzysztof.kozlowski@linaro.org, simon.horman@corigine.com
Cc: netdev@vger.kernel.org, Osama Muhammad <osmtendev@gmail.com>
Subject: [PATCH v2] nfcsim.c: Fix error checking for debugfs_create_dir
Date: Thu, 25 May 2023 22:27:46 +0500	[thread overview]
Message-ID: <20230525172746.17710-1-osmtendev@gmail.com> (raw)

This patch fixes the error checking in nfcsim.c.
The DebugFS kernel API is developed in
a way that the caller can safely ignore the errors that
occur during the creation of DebugFS nodes.

Signed-off-by: Osama Muhammad <osmtendev@gmail.com>

---

changes since v1:
        -Dropped the error checking for debugfs_create_dir
---
 drivers/nfc/nfcsim.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/nfc/nfcsim.c b/drivers/nfc/nfcsim.c
index 44eeb17ae48d..a55381f80cd6 100644
--- a/drivers/nfc/nfcsim.c
+++ b/drivers/nfc/nfcsim.c
@@ -336,10 +336,6 @@ static struct dentry *nfcsim_debugfs_root;
 static void nfcsim_debugfs_init(void)
 {
 	nfcsim_debugfs_root = debugfs_create_dir("nfcsim", NULL);
-
-	if (!nfcsim_debugfs_root)
-		pr_err("Could not create debugfs entry\n");
-
 }
 
 static void nfcsim_debugfs_remove(void)
-- 
2.34.1


             reply	other threads:[~2023-05-25 17:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-25 17:27 Osama Muhammad [this message]
2023-05-26  7:30 ` [PATCH v2] nfcsim.c: Fix error checking for debugfs_create_dir Simon Horman
2023-05-26 11:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230525172746.17710-1-osmtendev@gmail.com \
    --to=osmtendev@gmail.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=simon.horman@corigine.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).