* [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call
@ 2023-05-28 14:09 Andy Shevchenko
2023-05-29 8:12 ` Miquel Raynal
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Andy Shevchenko @ 2023-05-28 14:09 UTC (permalink / raw)
To: Stefan Schmidt, linux-wpan, netdev, linux-kernel
Cc: Alexander Aring, Miquel Raynal, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Andy Shevchenko
There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
GPIO sysfs is deprecated. That said, simply drop the stray call.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/net/ieee802154/ca8210.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
index a2d242034220..f9b10e84de06 100644
--- a/drivers/net/ieee802154/ca8210.c
+++ b/drivers/net/ieee802154/ca8210.c
@@ -2855,7 +2855,6 @@ static int ca8210_interrupt_init(struct spi_device *spi)
);
if (ret) {
dev_crit(&spi->dev, "request_irq %d failed\n", pdata->irq_id);
- gpiod_unexport(gpio_to_desc(pdata->gpio_irq));
gpio_free(pdata->gpio_irq);
}
--
2.40.0.1.gaa8946217a0b
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call
2023-05-28 14:09 [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call Andy Shevchenko
@ 2023-05-29 8:12 ` Miquel Raynal
2023-06-01 16:32 ` Andy Shevchenko
2023-05-30 7:42 ` Simon Horman
2023-06-06 18:52 ` Miquel Raynal
2 siblings, 1 reply; 10+ messages in thread
From: Miquel Raynal @ 2023-05-29 8:12 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Stefan Schmidt, linux-wpan, netdev, linux-kernel, Alexander Aring,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Hi Andy,
andriy.shevchenko@linux.intel.com wrote on Sun, 28 May 2023 17:09:38
+0300:
> There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
> The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
> GPIO sysfs is deprecated. That said, simply drop the stray call.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Any reason not to consider a backport into stable kernels?
Cc: stable + Fixes would certainly be welcome in this case?
> ---
> drivers/net/ieee802154/ca8210.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
> index a2d242034220..f9b10e84de06 100644
> --- a/drivers/net/ieee802154/ca8210.c
> +++ b/drivers/net/ieee802154/ca8210.c
> @@ -2855,7 +2855,6 @@ static int ca8210_interrupt_init(struct spi_device *spi)
> );
> if (ret) {
> dev_crit(&spi->dev, "request_irq %d failed\n", pdata->irq_id);
> - gpiod_unexport(gpio_to_desc(pdata->gpio_irq));
> gpio_free(pdata->gpio_irq);
> }
>
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call
2023-05-29 8:12 ` Miquel Raynal
@ 2023-06-01 16:32 ` Andy Shevchenko
0 siblings, 0 replies; 10+ messages in thread
From: Andy Shevchenko @ 2023-06-01 16:32 UTC (permalink / raw)
To: Miquel Raynal
Cc: Stefan Schmidt, linux-wpan, netdev, linux-kernel, Alexander Aring,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
On Mon, May 29, 2023 at 10:12:13AM +0200, Miquel Raynal wrote:
> andriy.shevchenko@linux.intel.com wrote on Sun, 28 May 2023 17:09:38
> +0300:
>
> > There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
> > The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
> > GPIO sysfs is deprecated. That said, simply drop the stray call.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Any reason not to consider a backport into stable kernels?
> Cc: stable + Fixes would certainly be welcome in this case?
I don't think it's justified for stable. It doesn't fix any existing regression
as far as I understand.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call
2023-05-28 14:09 [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call Andy Shevchenko
2023-05-29 8:12 ` Miquel Raynal
@ 2023-05-30 7:42 ` Simon Horman
2023-06-05 14:09 ` Andy Shevchenko
2023-06-06 18:52 ` Miquel Raynal
2 siblings, 1 reply; 10+ messages in thread
From: Simon Horman @ 2023-05-30 7:42 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Stefan Schmidt, linux-wpan, netdev, linux-kernel, Alexander Aring,
Miquel Raynal, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
On Sun, May 28, 2023 at 05:09:38PM +0300, Andy Shevchenko wrote:
> There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
> The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
> GPIO sysfs is deprecated. That said, simply drop the stray call.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call
2023-05-30 7:42 ` Simon Horman
@ 2023-06-05 14:09 ` Andy Shevchenko
2023-06-06 9:33 ` Alexander Aring
0 siblings, 1 reply; 10+ messages in thread
From: Andy Shevchenko @ 2023-06-05 14:09 UTC (permalink / raw)
To: Simon Horman
Cc: Stefan Schmidt, linux-wpan, netdev, linux-kernel, Alexander Aring,
Miquel Raynal, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
On Tue, May 30, 2023 at 09:42:20AM +0200, Simon Horman wrote:
> On Sun, May 28, 2023 at 05:09:38PM +0300, Andy Shevchenko wrote:
> > There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
> > The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
> > GPIO sysfs is deprecated. That said, simply drop the stray call.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
Thank you!
Can this be applied now?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call
2023-06-05 14:09 ` Andy Shevchenko
@ 2023-06-06 9:33 ` Alexander Aring
2023-06-06 9:47 ` Miquel Raynal
0 siblings, 1 reply; 10+ messages in thread
From: Alexander Aring @ 2023-06-06 9:33 UTC (permalink / raw)
To: Miquel Raynal
Cc: Simon Horman, Stefan Schmidt, linux-wpan, netdev, linux-kernel,
Alexander Aring, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Andy Shevchenko
Hi,
On Mon, Jun 5, 2023 at 10:12 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Tue, May 30, 2023 at 09:42:20AM +0200, Simon Horman wrote:
> > On Sun, May 28, 2023 at 05:09:38PM +0300, Andy Shevchenko wrote:
> > > There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
> > > The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
> > > GPIO sysfs is deprecated. That said, simply drop the stray call.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > Reviewed-by: Simon Horman <simon.horman@corigine.com>
>
> Thank you!
> Can this be applied now?
ping, Miquel? :)
- Alex
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call
2023-06-06 9:33 ` Alexander Aring
@ 2023-06-06 9:47 ` Miquel Raynal
2023-06-06 9:50 ` Alexander Aring
2023-06-06 13:03 ` Andy Shevchenko
0 siblings, 2 replies; 10+ messages in thread
From: Miquel Raynal @ 2023-06-06 9:47 UTC (permalink / raw)
To: Alexander Aring
Cc: Simon Horman, Stefan Schmidt, linux-wpan, netdev, linux-kernel,
Alexander Aring, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Andy Shevchenko
aahringo@redhat.com wrote on Tue, 6 Jun 2023 05:33:47 -0400:
> Hi,
>
> On Mon, Jun 5, 2023 at 10:12 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > On Tue, May 30, 2023 at 09:42:20AM +0200, Simon Horman wrote:
> > > On Sun, May 28, 2023 at 05:09:38PM +0300, Andy Shevchenko wrote:
> > > > There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
> > > > The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
> > > > GPIO sysfs is deprecated. That said, simply drop the stray call.
> > > >
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > >
> > > Reviewed-by: Simon Horman <simon.horman@corigine.com>
> >
> > Thank you!
> > Can this be applied now?
>
> ping, Miquel? :)
I already applied it locally, but I am trying to fix my "thanks for
patch" routine to not tell you it was applied on the mtd tree :-p
Cheers,
Miquèl
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call
2023-06-06 9:47 ` Miquel Raynal
@ 2023-06-06 9:50 ` Alexander Aring
2023-06-06 13:03 ` Andy Shevchenko
1 sibling, 0 replies; 10+ messages in thread
From: Alexander Aring @ 2023-06-06 9:50 UTC (permalink / raw)
To: Miquel Raynal
Cc: Simon Horman, Stefan Schmidt, linux-wpan, netdev, linux-kernel,
Alexander Aring, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Andy Shevchenko
Hi Miquel,
On Tue, Jun 6, 2023 at 5:47 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
>
> aahringo@redhat.com wrote on Tue, 6 Jun 2023 05:33:47 -0400:
>
> > Hi,
> >
> > On Mon, Jun 5, 2023 at 10:12 AM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > On Tue, May 30, 2023 at 09:42:20AM +0200, Simon Horman wrote:
> > > > On Sun, May 28, 2023 at 05:09:38PM +0300, Andy Shevchenko wrote:
> > > > > There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
> > > > > The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
> > > > > GPIO sysfs is deprecated. That said, simply drop the stray call.
> > > > >
> > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > >
> > > > Reviewed-by: Simon Horman <simon.horman@corigine.com>
> > >
> > > Thank you!
> > > Can this be applied now?
> >
> > ping, Miquel? :)
>
> I already applied it locally, but I am trying to fix my "thanks for
> patch" routine to not tell you it was applied on the mtd tree :-p
okay no problem. Fully understandable as we have a new workflow
mechanism for 802.15.4.
Thanks. :)
- Alex
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call
2023-06-06 9:47 ` Miquel Raynal
2023-06-06 9:50 ` Alexander Aring
@ 2023-06-06 13:03 ` Andy Shevchenko
1 sibling, 0 replies; 10+ messages in thread
From: Andy Shevchenko @ 2023-06-06 13:03 UTC (permalink / raw)
To: Miquel Raynal
Cc: Alexander Aring, Simon Horman, Stefan Schmidt, linux-wpan, netdev,
linux-kernel, Alexander Aring, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
On Tue, Jun 06, 2023 at 11:47:43AM +0200, Miquel Raynal wrote:
> aahringo@redhat.com wrote on Tue, 6 Jun 2023 05:33:47 -0400:
> > On Mon, Jun 5, 2023 at 10:12 AM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > > On Tue, May 30, 2023 at 09:42:20AM +0200, Simon Horman wrote:
> > > > On Sun, May 28, 2023 at 05:09:38PM +0300, Andy Shevchenko wrote:
> > > > > There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
> > > > > The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
> > > > > GPIO sysfs is deprecated. That said, simply drop the stray call.
> > > > >
> > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > >
> > > > Reviewed-by: Simon Horman <simon.horman@corigine.com>
> > >
> > > Thank you!
> > > Can this be applied now?
> >
> > ping, Miquel? :)
>
> I already applied it locally, but I am trying to fix my "thanks for
> patch" routine to not tell you it was applied on the mtd tree :-p
Good to know and thank you!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call
2023-05-28 14:09 [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call Andy Shevchenko
2023-05-29 8:12 ` Miquel Raynal
2023-05-30 7:42 ` Simon Horman
@ 2023-06-06 18:52 ` Miquel Raynal
2 siblings, 0 replies; 10+ messages in thread
From: Miquel Raynal @ 2023-06-06 18:52 UTC (permalink / raw)
To: Andy Shevchenko, Stefan Schmidt, linux-wpan, netdev, linux-kernel
Cc: Miquel Raynal, Alexander Aring, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
On Sun, 2023-05-28 at 14:09:38 UTC, Andy Shevchenko wrote:
> There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
> The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
> GPIO sysfs is deprecated. That said, simply drop the stray call.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/wpan/wpan-next.git staging, thanks.
Miquel
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-06-06 18:53 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-28 14:09 [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call Andy Shevchenko
2023-05-29 8:12 ` Miquel Raynal
2023-06-01 16:32 ` Andy Shevchenko
2023-05-30 7:42 ` Simon Horman
2023-06-05 14:09 ` Andy Shevchenko
2023-06-06 9:33 ` Alexander Aring
2023-06-06 9:47 ` Miquel Raynal
2023-06-06 9:50 ` Alexander Aring
2023-06-06 13:03 ` Andy Shevchenko
2023-06-06 18:52 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).