From: Jonathan Cameron <jic23@kernel.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: andy.shevchenko@gmail.com,
"Matti Vaittinen" <matti.vaittinen@fi.rohmeurope.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Daniel Scally" <djrscally@gmail.com>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Wolfram Sang" <wsa@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Andreas Klinger" <ak@it-klinger.de>,
"Marcin Wojtas" <mw@semihalf.com>,
"Russell King" <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Paul Cercueil" <paul@crapouillou.net>,
"Akhil R" <akhilrajeev@nvidia.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org,
netdev@vger.kernel.org, openbmc@lists.ozlabs.org,
linux-gpio@vger.kernel.org, linux-mips@vger.kernel.org
Subject: Re: [PATCH v5 3/8] net-next: mvpp2: relax return value check for IRQ get
Date: Sun, 28 May 2023 20:14:07 +0100 [thread overview]
Message-ID: <20230528201407.394235f5@jic23-huawei> (raw)
In-Reply-To: <6e94c838-886d-3c58-3fa0-175501f57f56@gmail.com>
On Mon, 22 May 2023 08:15:01 +0300
Matti Vaittinen <mazziesaccount@gmail.com> wrote:
> Hi Andy,
>
> On 5/21/23 20:19, andy.shevchenko@gmail.com wrote:
> > Fri, May 19, 2023 at 02:01:47PM +0300, Matti Vaittinen kirjoitti:
> >> fwnode_irq_get[_byname]() were changed to not return 0 anymore.
> >>
> >> Drop check for return value 0.
> >
> > ...
> >
> >> - if (v->irq <= 0) {
> >> + if (v->irq < 0) {
> >> ret = -EINVAL;
> >
> > ret = v->irq;
> >
> > ?
>
> For me that seems to be correct, yes. This, however, would be a
> functional change and in my opinion it should be done separately from
> this API change.
Ah. I commented on this as well in v6. Roll us that separate patch
and I expect we'll both be happy ;)
Jonathan
>
> >
> >> goto err;
> >> }
> >
>
next prev parent reply other threads:[~2023-05-28 18:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 11:00 [PATCH v5 0/8] fix fwnode_irq_get[_byname()] returnvalue Matti Vaittinen
2023-05-19 11:00 ` [PATCH v5 1/8] drivers: fwnode: fix fwnode_irq_get[_byname]() Matti Vaittinen
2023-05-21 17:13 ` andy.shevchenko
2023-05-19 11:01 ` [PATCH v5 2/8] iio: mb1232: relax return value check for IRQ get Matti Vaittinen
2023-05-20 15:32 ` Jonathan Cameron
2023-05-21 17:14 ` andy.shevchenko
2023-05-19 11:01 ` [PATCH v5 3/8] net-next: mvpp2: " Matti Vaittinen
2023-05-21 17:19 ` andy.shevchenko
2023-05-22 5:15 ` Matti Vaittinen
2023-05-28 19:14 ` Jonathan Cameron [this message]
2023-05-19 11:02 ` [PATCH v5 4/8] pinctrl: wpcm450: " Matti Vaittinen
2023-05-21 17:20 ` andy.shevchenko
2023-05-22 5:16 ` Matti Vaittinen
2023-05-19 11:02 ` [PATCH v5 5/8] pinctrl: ingenic: " Matti Vaittinen
2023-05-19 11:02 ` [PATCH v5 6/8] pinctrl: pistachio: " Matti Vaittinen
2023-05-19 11:04 ` [PATCH v5 7/8] iio: cdc: ad7150: " Matti Vaittinen
2023-05-20 15:30 ` Jonathan Cameron
2023-05-19 11:05 ` [PATCH v5 8/8] i2c: i2c-smbus: fwnode_irq_get_byname() return value fix Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230528201407.394235f5@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=ak@it-klinger.de \
--cc=akhilrajeev@nvidia.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=davem@davemloft.net \
--cc=djrscally@gmail.com \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=j.neuschaefer@gmx.net \
--cc=kuba@kernel.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=pabeni@redhat.com \
--cc=paul@crapouillou.net \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).