From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73F977E5 for ; Wed, 31 May 2023 04:30:50 +0000 (UTC) Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 279B8186; Tue, 30 May 2023 21:30:49 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 303408167; Wed, 31 May 2023 04:30:44 +0000 (UTC) Date: Wed, 31 May 2023 07:30:40 +0300 From: Tony Lindgren To: Judith Mendez Cc: Chandrasekar Ramakrishnan , linux-can@vger.kernel.org, Wolfgang Grandegger , Marc Kleine-Budde , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Schuyler Patton , Tero Kristo , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, Oliver Hartkopp , Simon Horman , Conor Dooley Subject: Re: [PATCH v8 2/2] can: m_can: Add hrtimer to generate software interrupt Message-ID: <20230531043040.GQ14287@atomide.com> References: <20230530224820.303619-1-jm@ti.com> <20230530224820.303619-3-jm@ti.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230530224820.303619-3-jm@ti.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net * Judith Mendez [230530 22:48]: > Introduce timer polling method to MCAN since some SoCs may not > have M_CAN interrupt routed to A53 Linux and do not have > interrupt property in device tree M_CAN node. > > On AM62x SoC, MCANs on MCU domain do not have hardware interrupt > routed to A53 Linux, instead they will use timer polling method. > > Add an hrtimer to MCAN class device. Each MCAN will have its own > hrtimer instantiated if there is no hardware interrupt found in > device tree M_CAN node. The timer will generate a software > interrupt every 1 ms. In hrtimer callback, we check if there is > a transaction pending by reading a register, then process by > calling the isr if there is. Reviewed-by: Tony Lindgren