From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34E8FD307 for ; Wed, 31 May 2023 08:31:53 +0000 (UTC) Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26C00107 for ; Wed, 31 May 2023 01:31:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1685521904; x=1717057904; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Jkg2+fJWa8hrdyQ4dam9yx7OtoRsLNNJqpOrVzzqlTc=; b=agr09DSdBNo8pkvkHEajk6X/wSIYScl5NJQ0An/oqIc6U2xyiX16t3m4 UcmpX1EK0AFuOCh6sUcedkb9iuczqQEPXZ9cVYIyEsyQDpyjTlJNDwmE8 nFSFG6uHEMVWszK6oQqeiG6pLkSbu4o9T81RhPp83pXSARg2VYNSU1NnP 9WAp3S8d+2e5a0I/ECiJwQ/BGEPc8/WngWVfoSbiCgfSG8LfuLq9IVOEQ z6nV0nCkLsBXVR0X2lwgzKwP/gCmbuzJAb3BIsjNolYcU6zlcXKpPHMUW 1PV1NYjI4hnqVrx09OaU+pCGRcEe37mVk/KZMRRtJ9NKMZAA+t4RlhCeX g==; X-IronPort-AV: E=Sophos;i="6.00,205,1681196400"; d="scan'208";a="218123149" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 31 May 2023 01:31:43 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 31 May 2023 01:31:43 -0700 Received: from DEN-LT-70577 (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Wed, 31 May 2023 01:31:41 -0700 Date: Wed, 31 May 2023 08:31:41 +0000 From: Daniel Machon To: Petr Machata CC: , , , Subject: Re: [PATCH iproute2-next v2 2/8] dcb: app: modify dcb-app print functions for dcb-rewr reuse Message-ID: <20230531083141.ijtwsfxa3javczdf@DEN-LT-70577> References: <20230510-dcb-rewr-v2-0-9f38e688117e@microchip.com> <20230510-dcb-rewr-v2-2-9f38e688117e@microchip.com> <87leh75aek.fsf@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <87leh75aek.fsf@nvidia.com> X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net > Daniel Machon writes: > > > Where dcb-app requires protocol to be the printed key, dcb-rewr requires > > it to be the priority. Adapt existing dcb-app print functions for this. > > > > dcb_app_print_filtered() has been modified, to take two callbacks; one > > for printing the entire string (pid and prio), and one for the pid type > > (dec, hex, dscp, pcp). This saves us for making one dedicated function > > for each pid type for both app and rewr. > > > > dcb_app_print_key_*() functions have been renamed to > > dcb_app_print_pid_*() to align with new situation. Also, none of them > > will print the colon anymore. > > > > Signed-off-by: Daniel Machon > > There are about four patches included in this one patch: the %d->%u > change, the colon shenanigans, the renaming, and prototype change of > dcb_app_print_filtered(). > > I think the code is OK, but I would appreciate splitting into a patch > per feature. Actually, IMHO, the 'colon shenanigans' does not make much sense in a patch of its own, since its not really a standalone feature, but rather some change that is required for the prototype change of dcb_app_print_filtered?