From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Kurt Kanzenbach <kurt@linutronix.de>,
Gerhard Engleder <gerhard@engleder-embedded.com>,
Amritha Nambiar <amritha.nambiar@intel.com>,
Ferenc Fejes <ferenc.fejes@ericsson.com>,
Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
Roger Quadros <rogerq@kernel.org>,
Pranavi Somisetty <pranavi.somisetty@amd.com>,
Harini Katakam <harini.katakam@amd.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>,
Mohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>,
Oleksij Rempel <linux@rempel-privat.de>,
Jacob Keller <jacob.e.keller@intel.com>,
linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
UNGLinuxDriver@microchip.com,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
intel-wired-lan@lists.osuosl.org,
Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
Subject: Re: [PATCH net-next 3/5] net/sched: taprio: add netlink reporting for offload statistics counters
Date: Wed, 31 May 2023 16:33:07 +0300 [thread overview]
Message-ID: <20230531133307.7oqrcujtqhw7olzj@skbuf> (raw)
In-Reply-To: <87wn0ptota.fsf@intel.com>
On Tue, May 30, 2023 at 03:52:17PM -0700, Vinicius Costa Gomes wrote:
> > + memset(stats, 0xff, sizeof(*stats));
>
> The only part that I didn't like, at first, was this, that the
> initialization of the offload struct is divided into two parts: one to
> set the command/tc, and one to set the "invalid/not set" value to all
> stats fields.
>
> I was thinking of adding a macro to do initialization of the stats
> fields, but it has a problem that it won't complain when a new field is
> added. Your solution should always work. I don't have better
> suggestions.
Right, it's no coincidence that it's where it is and the way it is.
Again, I drew inspiration from stats_prepare_data() in ethtool.
> Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Thanks for the review.
next prev parent reply other threads:[~2023-05-31 13:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 9:19 [PATCH net-next 0/5] xstats for tc-taprio Vladimir Oltean
2023-05-30 9:19 ` [PATCH net-next 1/5] net/sched: taprio: don't overwrite "sch" variable in taprio_dump_class_stats() Vladimir Oltean
2023-05-30 21:14 ` Vinicius Costa Gomes
2023-05-30 21:32 ` Vladimir Oltean
2023-05-30 22:33 ` Vinicius Costa Gomes
2023-05-30 9:19 ` [PATCH net-next 2/5] net/sched: taprio: replace tc_taprio_qopt_offload :: enable with a "cmd" enum Vladimir Oltean
2023-05-30 12:01 ` Horatiu Vultur
2023-05-30 12:20 ` Kurt Kanzenbach
2023-05-30 12:45 ` Zulkifli, Muhammad Husaini
2023-05-30 20:50 ` Gerhard Engleder
2023-05-31 17:08 ` Simon Horman
2023-05-31 17:10 ` Vladimir Oltean
2023-05-30 9:19 ` [PATCH net-next 3/5] net/sched: taprio: add netlink reporting for offload statistics counters Vladimir Oltean
2023-05-30 22:52 ` Vinicius Costa Gomes
2023-05-31 13:33 ` Vladimir Oltean [this message]
2023-05-31 10:54 ` Zulkifli, Muhammad Husaini
2023-05-30 9:19 ` [PATCH net-next 4/5] net: enetc: refactor enetc_setup_tc_taprio() to have a switch/case for cmd Vladimir Oltean
2023-05-30 9:19 ` [PATCH net-next 5/5] net: enetc: report statistics counters for taprio Vladimir Oltean
2023-05-31 9:10 ` [PATCH net-next 0/5] xstats for tc-taprio patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230531133307.7oqrcujtqhw7olzj@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=amritha.nambiar@intel.com \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=ferenc.fejes@ericsson.com \
--cc=gerhard@engleder-embedded.com \
--cc=harini.katakam@amd.com \
--cc=horatiu.vultur@microchip.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=mcoquelin.stm32@gmail.com \
--cc=michael.wei.hong.sit@intel.com \
--cc=mohammad.athari.ismail@intel.com \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=pranavi.somisetty@amd.com \
--cc=rogerq@kernel.org \
--cc=vinicius.gomes@intel.com \
--cc=xiaoliang.yang_1@nxp.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox