From: Jakub Kicinski <kuba@kernel.org>
To: Anjali Kulkarni <anjali.k.kulkarni@oracle.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"zbr@ioremap.net" <zbr@ioremap.net>,
"brauner@kernel.org" <brauner@kernel.org>,
"johannes@sipsolutions.net" <johannes@sipsolutions.net>,
"ecree.xilinx@gmail.com" <ecree.xilinx@gmail.com>,
"leon@kernel.org" <leon@kernel.org>,
"keescook@chromium.org" <keescook@chromium.org>,
"socketcan@hartkopp.net" <socketcan@hartkopp.net>,
"petrm@nvidia.com" <petrm@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v4 1/6] netlink: Reverse the patch which removed filtering
Date: Thu, 1 Jun 2023 09:43:14 -0700 [thread overview]
Message-ID: <20230601094314.61aa2d5b@kernel.org> (raw)
In-Reply-To: <6A9C1580-8B7B-42DB-B37A-A948F68E3FFF@oracle.com>
On Thu, 1 Jun 2023 16:34:08 +0000 Anjali Kulkarni wrote:
> > The code may have security implications, I really don't feel like I can
> > be the sole reviewer. There's a bunch of experts working at Oracle,
> > maybe you could get one of them to put their name on it? I can apply
> > the patches, I just want to be sure I'm not the _only_ reviewer.
>
> Thanks so much for your response. There is someone at Oracle who
> looked at this some time ago and is familiar enough with this to
> review the code - but he is not a kernel committer - he sends
> occasional patches upstream which get committed - would it be ok if
> he reviewed it along with you and then you could commit it? If you
> know of someone from Oracle who could also potentially review it,
> please let me know.
I meant someone seasoned. IMHO one of the benefits of employing
upstream experts for corporation like Oracle should be that you
can lean on them for reviews:
$ git log --format='%ae' --author='Oracle' --since='2 years ago' | sort | uniq -c | sort -rn
811 willy@infradead.org
312 rmk+kernel@armlinux.org.uk
91 Liam.Howlett@Oracle.com
60 vishal.moola@gmail.com
$ git log --format='%ae' --author='@oracle.com' --since='2 years ago' | sort | uniq -c | sort -rn | head -10
451 chuck.lever@oracle.com
154 michael.christie@oracle.com
118 nick.alcock@oracle.com
71 martin.petersen@oracle.com
59 mike.kravetz@oracle.com
58 sidhartha.kumar@oracle.com
55 liam.howlett@oracle.com
53 anand.jain@oracle.com
32 dai.ngo@oracle.com
32 allison.henderson@oracle.com
next prev parent reply other threads:[~2023-06-01 16:43 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 23:55 [PATCH v4 0/6] Process connector bug fixes & enhancements Anjali Kulkarni
2023-03-31 23:55 ` [PATCH v4 1/6] netlink: Reverse the patch which removed filtering Anjali Kulkarni
2023-04-01 4:08 ` Jakub Kicinski
2023-04-01 4:09 ` Jakub Kicinski
2023-04-01 18:24 ` Anjali Kulkarni
2023-04-01 19:12 ` Jakub Kicinski
2023-04-01 19:58 ` Anjali Kulkarni
2023-04-03 20:47 ` Jakub Kicinski
2023-04-02 2:32 ` Anjali Kulkarni
2023-04-03 20:50 ` Jakub Kicinski
2023-04-04 18:06 ` Anjali Kulkarni
2023-04-26 23:58 ` Anjali Kulkarni
2023-04-27 17:03 ` Jakub Kicinski
2023-05-11 16:04 ` Anjali Kulkarni
2023-06-01 16:15 ` Anjali Kulkarni
2023-06-01 16:24 ` Jakub Kicinski
2023-06-01 16:34 ` Anjali Kulkarni
2023-06-01 16:43 ` Jakub Kicinski [this message]
2023-06-01 16:49 ` Anjali Kulkarni
2023-03-31 23:55 ` [PATCH v4 2/6] netlink: Add new netlink_release function Anjali Kulkarni
2023-04-01 4:08 ` Jakub Kicinski
2023-03-31 23:55 ` [PATCH v4 3/6] connector/cn_proc: Add filtering to fix some bugs Anjali Kulkarni
2023-03-31 23:55 ` [PATCH v4 4/6] connector/cn_proc: Test code for proc connector Anjali Kulkarni
2023-03-31 23:55 ` [PATCH v4 5/6] connector/cn_proc: Performance improvements Anjali Kulkarni
2023-06-01 16:25 ` Jakub Kicinski
2023-06-01 16:38 ` Anjali Kulkarni
2023-06-01 16:48 ` Jakub Kicinski
2023-06-01 16:53 ` Anjali Kulkarni
2023-06-01 17:15 ` Jakub Kicinski
2023-06-02 22:23 ` Anjali Kulkarni
2023-06-02 23:02 ` Jakub Kicinski
2023-03-31 23:55 ` [PATCH v4 6/6] connector/cn_proc: Allow non-root users access Anjali Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230601094314.61aa2d5b@kernel.org \
--to=kuba@kernel.org \
--cc=anjali.k.kulkarni@oracle.com \
--cc=brauner@kernel.org \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=keescook@chromium.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=socketcan@hartkopp.net \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).