From: Jakub Kicinski <kuba@kernel.org>
To: Anjali Kulkarni <anjali.k.kulkarni@oracle.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
Evgeniy Polyakov <zbr@ioremap.net>,
Christian Brauner <brauner@kernel.org>,
"johannes@sipsolutions.net" <johannes@sipsolutions.net>,
"ecree.xilinx@gmail.com" <ecree.xilinx@gmail.com>,
"leon@kernel.org" <leon@kernel.org>,
"keescook@chromium.org" <keescook@chromium.org>,
"socketcan@hartkopp.net" <socketcan@hartkopp.net>,
"petrm@nvidia.com" <petrm@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v4 5/6] connector/cn_proc: Performance improvements
Date: Thu, 1 Jun 2023 10:15:14 -0700 [thread overview]
Message-ID: <20230601101514.775c631a@kernel.org> (raw)
In-Reply-To: <FD84A5B5-8C98-4796-8F69-5754C34D2172@oracle.com>
On Thu, 1 Jun 2023 16:53:07 +0000 Anjali Kulkarni wrote:
> > Is it possible to recode the sample so the format can be decided based
> > on cmd line argument? To be honest samples are kinda dead, it'd be best
> > if the code was rewritten to act as a selftest.
>
> Yes, I can recode to use a cmd line argument. Where would a selftest
> be committed?
The path flow is the same as for the sample, the file just goes to
tools/testing/selftests rather than samples/.
> This is kind of a self test in the sense that this is
> working code to test the other kernel code. What else is needed to
> make it a selftest?
Not much, really. I think the requirement is to exit with a non-zero
return code on failure, which you already do. 0 means success; 1 means
failure; 2 means skip, IIRC.
The main work in your case would be that the selftest needs to do its
checking and exit, so the stimuli must be triggered automatically.
(You can use a bash script to drive the events.)
next prev parent reply other threads:[~2023-06-01 17:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 23:55 [PATCH v4 0/6] Process connector bug fixes & enhancements Anjali Kulkarni
2023-03-31 23:55 ` [PATCH v4 1/6] netlink: Reverse the patch which removed filtering Anjali Kulkarni
2023-04-01 4:08 ` Jakub Kicinski
2023-04-01 4:09 ` Jakub Kicinski
2023-04-01 18:24 ` Anjali Kulkarni
2023-04-01 19:12 ` Jakub Kicinski
2023-04-01 19:58 ` Anjali Kulkarni
2023-04-03 20:47 ` Jakub Kicinski
2023-04-02 2:32 ` Anjali Kulkarni
2023-04-03 20:50 ` Jakub Kicinski
2023-04-04 18:06 ` Anjali Kulkarni
2023-04-26 23:58 ` Anjali Kulkarni
2023-04-27 17:03 ` Jakub Kicinski
2023-05-11 16:04 ` Anjali Kulkarni
2023-06-01 16:15 ` Anjali Kulkarni
2023-06-01 16:24 ` Jakub Kicinski
2023-06-01 16:34 ` Anjali Kulkarni
2023-06-01 16:43 ` Jakub Kicinski
2023-06-01 16:49 ` Anjali Kulkarni
2023-03-31 23:55 ` [PATCH v4 2/6] netlink: Add new netlink_release function Anjali Kulkarni
2023-04-01 4:08 ` Jakub Kicinski
2023-03-31 23:55 ` [PATCH v4 3/6] connector/cn_proc: Add filtering to fix some bugs Anjali Kulkarni
2023-03-31 23:55 ` [PATCH v4 4/6] connector/cn_proc: Test code for proc connector Anjali Kulkarni
2023-03-31 23:55 ` [PATCH v4 5/6] connector/cn_proc: Performance improvements Anjali Kulkarni
2023-06-01 16:25 ` Jakub Kicinski
2023-06-01 16:38 ` Anjali Kulkarni
2023-06-01 16:48 ` Jakub Kicinski
2023-06-01 16:53 ` Anjali Kulkarni
2023-06-01 17:15 ` Jakub Kicinski [this message]
2023-06-02 22:23 ` Anjali Kulkarni
2023-06-02 23:02 ` Jakub Kicinski
2023-03-31 23:55 ` [PATCH v4 6/6] connector/cn_proc: Allow non-root users access Anjali Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230601101514.775c631a@kernel.org \
--to=kuba@kernel.org \
--cc=anjali.k.kulkarni@oracle.com \
--cc=brauner@kernel.org \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=keescook@chromium.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=socketcan@hartkopp.net \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).