From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1DBF8466 for ; Fri, 2 Jun 2023 04:33:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92C72C433D2; Fri, 2 Jun 2023 04:33:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685680427; bh=rzdbk4UoCHxqOyDCfEQSEqkhPVCF5ZhNTciUeKk4crw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uNCNrf6TFuwuOIPyo0xPa137bdxnHl291nika4Kl3JAWUEiWFtVnDVRPvYINhy9Z2 ctapbpAra5CSwKsYwgfjqd7conOZJvj2mMsjP3wj2caADHk5H2iltpmaQ4i/TQ78ay REBCAuQ/Log6kAsvpO1yMfeLjdAnzGWvqDfBFqqXZfbmoz/yWnGLAJvtSpL6/36PfO lDvqy5i1wykQXIVGzQLwBpXzW63EnVcJhY0fu9VuMzqJdBkiaB3mAew1HWOvO9CeSE D57OAMItT3jIswotPMPLQWgQn30IQiAjRjkbs2ogMADfeieelKIODmwzu2XwhZ2GEL omIc8gHQgNLRg== Date: Thu, 1 Jun 2023 21:33:45 -0700 From: Jakub Kicinski To: "Russell King (Oracle)" Cc: Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Paolo Abeni , Dan Carpenter , Oleksij Rempel , netdev@vger.kernel.org Subject: Re: [PATCH net-next] net: phylib: fix phy_read*_poll_timeout() Message-ID: <20230601213345.3aaee66a@kernel.org> In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 01 Jun 2023 16:48:12 +0100 Russell King (Oracle) wrote: > + __ret = read_poll_timeout(__val = phy_read, val, \ ^^^ Is this not __val on purpose?