From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id D33F6332E1
	for <netdev@vger.kernel.org>; Fri,  2 Jun 2023 16:39:31 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A95E1C433D2;
	Fri,  2 Jun 2023 16:39:30 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1685723971;
	bh=8bHNswoYHnSXiwlo70dxM9TzF2xyp76+5Txn9KrkcSE=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=EP2oraAs3QhbPgvUBRn9rQxBwby+mZyogAhpZlMjbPgtVQgzUfSn85GgQNt9QQ7cE
	 J6rqiysXHUN+V/NdAGZLcUM9jYpgRlGe4lKDRKMgd6qAkKpNRApYIIKXCiPzVvbbl9
	 ecnWbqlQV/DkEX6WUbgxsXxZ1Ogdj4DveBysM9xfVOOczmSaX+OCBvIbxwRC+ZQMKC
	 WH5FQuQdl7JaE+UeMiK0hwRK/mqoXS1ebNE+jECkk7XLJcQdpZ6YSr4FMjNbjplfAu
	 xxaiju23JPAXST7BkvUu2LfePX9M4nQk70yeNO9XLnGqjWJpvKl6rjXZZRT+q9OVNq
	 HWjsvMb/W23tg==
Date: Fri, 2 Jun 2023 09:39:29 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: David Howells <dhowells@redhat.com>, netdev@vger.kernel.org, "David S.
 Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Paolo
 Abeni <pabeni@redhat.com>, Willem de Bruijn
 <willemdebruijn.kernel@gmail.com>, David Ahern <dsahern@kernel.org>,
 Matthew Wilcox <willy@infradead.org>, Jens Axboe <axboe@kernel.dk>,
 linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chuck Lever
 <chuck.lever@oracle.com>, Boris Pismenny <borisp@nvidia.com>, John
 Fastabend <john.fastabend@gmail.com>, Christoph Hellwig <hch@infradead.org>
Subject: Re: Bug in short splice to socket?
Message-ID: <20230602093929.29fd447d@kernel.org>
In-Reply-To: <CAHk-=wgyAGUMHmQM-5Eb556z5xiHZB7cF05qjrtUH4F7P-1rSA@mail.gmail.com>
References: <CAHk-=wji_2UwFMkUYkygsYRek05NwaQkH-vA=yKQtQS9Js+urQ@mail.gmail.com>
	<20230524153311.3625329-1-dhowells@redhat.com>
	<20230524153311.3625329-10-dhowells@redhat.com>
	<20230526180844.73745d78@kernel.org>
	<499791.1685485603@warthog.procyon.org.uk>
	<CAHk-=wgeixW3cc=Ys8eL0_+22FUhqeEru=nzRrSXy1U4YQdE-w@mail.gmail.com>
	<CAHk-=wghhHghtvU_SzXxAzfaX35BkNs-x91-Vj6+6tnVEhPrZg@mail.gmail.com>
	<832277.1685630048@warthog.procyon.org.uk>
	<909595.1685639680@warthog.procyon.org.uk>
	<20230601212043.720f85c2@kernel.org>
	<952877.1685694220@warthog.procyon.org.uk>
	<CAHk-=wjvgL5nyZmpYRWBfab4NKvfQ7NjUvUhE3a3wYTyTEHdfQ@mail.gmail.com>
	<1227123.1685706296@warthog.procyon.org.uk>
	<CAHk-=wgyAGUMHmQM-5Eb556z5xiHZB7cF05qjrtUH4F7P-1rSA@mail.gmail.com>
Precedence: bulk
X-Mailing-List: netdev@vger.kernel.org
List-Id: <netdev.vger.kernel.org>
List-Subscribe: <mailto:netdev+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:netdev+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 2 Jun 2023 08:11:47 -0400 Linus Torvalds wrote:
> If then some *real* load ends up showing a regression, we may just be
> screwed. Our current behavior may be buggy, but we have the rule that
> once user space depends on kernel bugs, they become features pretty
> much by definition, however much we might dislike it.
> 
> At that point, we'll have to see what we can do - if anything.

Can we have a provisional plan of how we'll fix it if someone does
complain? We can't just revert David's work, and if none of the
solutions are appealing - socket implementations may be left holding
the bag.

I dislike the magic zero sends, and I think you do, too. In case of TLS
its unclear whether we should generate an empty record (like UDP would).

Can we add an optional splice_end / short_splice / splice_underflow /
splice_I_did_not_mean_to_set_more_on_the_previous_call_sorry callback
to struct file_operations?