From: Jakub Kicinski <kuba@kernel.org>
To: Shannon Nelson <shannon.nelson@amd.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<brett.creeley@amd.com>, <drivers@pensando.io>,
Nitya Sunkad <nitya.sunkad@amd.com>
Subject: Re: [PATCH net-next] ionic: add support for ethtool extended stat link_down_count
Date: Fri, 2 Jun 2023 23:47:08 -0700 [thread overview]
Message-ID: <20230602234708.03fbb00e@kernel.org> (raw)
In-Reply-To: <20230602173252.35711-1-shannon.nelson@amd.com>
On Fri, 2 Jun 2023 10:32:52 -0700 Shannon Nelson wrote:
> Following the example of 9a0f830f8026 ("ethtool: linkstate: add a statistic
> for PHY down events"), added support for link down events.
>
> Added callback ionic_get_link_ext_stats to ionic_ethtool.c to support
> link_down_count, a property of netdev that gets incremented every time
> the device link goes down.
Hm, could you say more about motivation? The ethtool stat is supposed to
come from HW and represent PHY-level flap count. It's used primarily to
find bad cables in a datacenter. Is this also the use case for ionic?
It's unclear to me whether ionic interfaces are seeing an actual PHY or
just some virtual link state of the IPU and in the latter case it's not
really a match.
next prev parent reply other threads:[~2023-06-03 6:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 17:32 [PATCH net-next] ionic: add support for ethtool extended stat link_down_count Shannon Nelson
2023-06-03 6:11 ` Siddharth Vadapalli
2023-06-05 16:31 ` Shannon Nelson
2023-06-03 6:47 ` Jakub Kicinski [this message]
2023-06-05 16:26 ` Shannon Nelson
2023-06-05 19:05 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230602234708.03fbb00e@kernel.org \
--to=kuba@kernel.org \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=drivers@pensando.io \
--cc=netdev@vger.kernel.org \
--cc=nitya.sunkad@amd.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).