From: Jakub Kicinski <kuba@kernel.org>
To: Ding Hui <dinghui@sangfor.com.cn>
Cc: Alexander Duyck <alexander.duyck@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
pengdonglin@sangfor.com.cn, huangcun@sangfor.com.cn
Subject: Re: [PATCH net-next] net: ethtool: Fix out-of-bounds copy to user
Date: Sun, 4 Jun 2023 10:47:18 -0700 [thread overview]
Message-ID: <20230604104718.4bf45faf@kernel.org> (raw)
In-Reply-To: <5f0f2bab-ae36-8b13-2c6d-c69c6ff4a43f@sangfor.com.cn>
On Sat, 3 Jun 2023 15:11:29 +0800 Ding Hui wrote:
> Yes.
>
> I checked the others ioctl (e.g. ethtool_get_eeprom(), ethtool_get_features()),
> and searched the git log of ethtool utility, so I think that is an implicit
> rule and the check is missed in kernel where the patch involves.
>
> Without this rule, we cannot guarantee the safety of copy to user.
>
> Should we keep to be compatible with that incorrect userspace usage?
If such incorrect user space exists we do, if it doesn't we don't.
Problem is that we don't know what exists out there.
Maybe we can add a pr_err_once() complaining about bad usage for now
and see if anyone reports back that they are hitting it?
next prev parent reply other threads:[~2023-06-04 17:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 11:28 [PATCH net-next] net: ethtool: Fix out-of-bounds copy to user Ding Hui
2023-06-01 15:04 ` Alexander H Duyck
2023-06-02 1:46 ` Ding Hui
2023-06-02 12:26 ` Andrew Lunn
2023-06-02 15:01 ` Ding Hui
2023-06-02 15:37 ` Andrew Lunn
2023-06-02 16:01 ` Alexander Duyck
2023-06-02 16:37 ` Andrew Lunn
2023-06-02 18:02 ` Alexander Duyck
2023-06-03 1:51 ` Ding Hui
2023-06-03 5:55 ` Jakub Kicinski
2023-06-03 7:11 ` Ding Hui
2023-06-04 17:47 ` Jakub Kicinski [this message]
2023-06-05 3:39 ` Ding Hui
2023-06-05 18:39 ` Jakub Kicinski
2023-06-08 9:06 ` Ding Hui
2023-06-08 14:17 ` Alexander Duyck
2023-06-09 15:25 ` Ding Hui
2023-06-09 17:13 ` Jakub Kicinski
2023-06-09 17:59 ` Alexander Duyck
2023-06-10 3:47 ` Ding Hui
2023-06-10 4:01 ` Ding Hui
2023-06-02 15:30 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230604104718.4bf45faf@kernel.org \
--to=kuba@kernel.org \
--cc=alexander.duyck@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dinghui@sangfor.com.cn \
--cc=edumazet@google.com \
--cc=huangcun@sangfor.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pengdonglin@sangfor.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).