From: Stephen Hemminger <stephen@networkplumber.org>
To: Ido Schimmel <idosch@idosch.org>
Cc: Vladimir Nikishkin <vladimir@nikishkin.pw>,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com,
eng.alaamohamedsoliman.am@gmail.com, gnault@redhat.com,
razor@blackwall.org, idosch@nvidia.com, liuhangbin@gmail.com,
eyal.birger@gmail.com, jtoppins@redhat.com
Subject: Re: [PATCH iproute2-next v7] ip-link: add support for nolocalbypass in vxlan
Date: Mon, 5 Jun 2023 08:02:17 -0700 [thread overview]
Message-ID: <20230605080217.441e1973@hermes.local> (raw)
In-Reply-To: <ZH2cUO7pFnU/tcXL@shredder>
On Mon, 5 Jun 2023 11:26:56 +0300
Ido Schimmel <idosch@idosch.org> wrote:
> On Mon, Jun 05, 2023 at 02:47:12PM +0800, Vladimir Nikishkin wrote:
> >
> > Ido Schimmel <idosch@idosch.org> writes:
> >
> > > On Sun, Jun 04, 2023 at 10:00:51PM +0800, Vladimir Nikishkin wrote:
> > >> Add userspace support for the [no]localbypass vxlan netlink
> > >> attribute. With localbypass on (default), the vxlan driver processes
> > >> the packets destined to the local machine by itself, bypassing the
> > >> userspace nework stack. With nolocalbypass the packets are always
> > >> forwarded to the userspace network stack, so userspace programs,
> > >> such as tcpdump have a chance to process them.
> > >>
> > >> Signed-off-by: Vladimir Nikishkin <vladimir@nikishkin.pw>
> > >> ---
> > >> v6=>v7:
> > >> Use the new vxlan_opts data structure. Rely on the printing loop
> > >> in vxlan_print_opt when printing the value of [no] localbypass.
> > >
> > > Stephen's changes are still not present in the next branch so this patch
> > > does not apply
> >
> > Sorry for the confusion, I thought that the tree to develop against is
> > git://git.kernel.org/pub/scm/linux/kernel/git/shemminger/iproute2.git
>
> iproute2-next is developed at
> git://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git
>
> See the README file.
>
> Anyway, patch looks fine, but indentation is a bit off. Please fold this
> in:
David will to a merge from main to next if asked.
next prev parent reply other threads:[~2023-06-05 15:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-04 14:00 [PATCH iproute2-next v7] ip-link: add support for nolocalbypass in vxlan Vladimir Nikishkin
2023-06-05 6:36 ` Ido Schimmel
2023-06-05 6:47 ` Vladimir Nikishkin
2023-06-05 8:26 ` Ido Schimmel
2023-06-05 15:02 ` Stephen Hemminger [this message]
2023-06-05 15:14 ` Ido Schimmel
2023-06-05 15:19 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230605080217.441e1973@hermes.local \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eng.alaamohamedsoliman.am@gmail.com \
--cc=eyal.birger@gmail.com \
--cc=gnault@redhat.com \
--cc=idosch@idosch.org \
--cc=idosch@nvidia.com \
--cc=jtoppins@redhat.com \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=vladimir@nikishkin.pw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).