From: Jakub Kicinski <kuba@kernel.org>
To: Asmaa Mnebhi <asmaa@nvidia.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <cai.huoqing@linux.dev>,
<brgl@bgdev.pl>, <chenhao288@hisilicon.com>,
<huangguangbin2@huawei.com>,
David Thompson <davthompson@nvidia.com>
Subject: Re: [PATCH net-next v1 1/1] mlxbf_gige: Fix kernel panic at shutdown
Date: Mon, 5 Jun 2023 16:15:07 -0700 [thread overview]
Message-ID: <20230605161507.654a3c1b@kernel.org> (raw)
In-Reply-To: <20230602182443.25514-1-asmaa@nvidia.com>
On Fri, 2 Jun 2023 14:24:43 -0400 Asmaa Mnebhi wrote:
> There is a race condition happening during shutdown due to pending napi transactions.
> Since mlxbf_gige_poll is still running, it tries to access a NULL pointer and as a
> result causes a kernel panic.
> To fix this during shutdown, invoke mlxbf_gige_remove to disable and dequeue napi.
>
> Fixes: f92e1869d74e ("Add Mellanox BlueField Gigabit Ethernet driver")
> Signed-off-by: Asmaa Mnebhi <asmaa@nvidia.com>
Judging by the Fixes tag the problem can happen on 6.4-rc5 already,
right? So the tree in the [PATCH ] tag should have been net rather
than net-next?
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#git-trees-and-patch-flow
No need to repost confirmation is enough.
next prev parent reply other threads:[~2023-06-05 23:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 18:24 [PATCH net-next v1 1/1] mlxbf_gige: Fix kernel panic at shutdown Asmaa Mnebhi
2023-06-05 23:15 ` Jakub Kicinski [this message]
2023-06-06 12:25 ` Asmaa Mnebhi
2023-06-06 10:47 ` Paolo Abeni
2023-06-06 17:29 ` Jakub Kicinski
2023-06-07 13:54 ` Asmaa Mnebhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230605161507.654a3c1b@kernel.org \
--to=kuba@kernel.org \
--cc=asmaa@nvidia.com \
--cc=brgl@bgdev.pl \
--cc=cai.huoqing@linux.dev \
--cc=chenhao288@hisilicon.com \
--cc=davem@davemloft.net \
--cc=davthompson@nvidia.com \
--cc=edumazet@google.com \
--cc=huangguangbin2@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).