From: Jakub Kicinski <kuba@kernel.org>
To: Justin Chen <justin.chen@broadcom.com>
Cc: netdev@vger.kernel.org, simon.horman@corigine.com,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
Daniil Tatianin <d-tatianin@yandex-team.ru>,
Marco Bonelli <marco@mebeim.net>, Gal Pressman <gal@nvidia.com>,
Jiri Pirko <jiri@resnulli.us>,
Sean Anderson <sean.anderson@seco.com>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH net-next] ethtool: ioctl: improve error checking for set_wol
Date: Tue, 6 Jun 2023 20:54:37 -0700 [thread overview]
Message-ID: <20230606205437.49378d25@kernel.org> (raw)
In-Reply-To: <1685990778-34039-1-git-send-email-justin.chen@broadcom.com>
On Mon, 5 Jun 2023 11:46:16 -0700 Justin Chen wrote:
> + if (wol.wolopts & ~cur_wol.supported)
> + return -EOPNOTSUPP;
One small comment - I think we should return -EINVAL here.
That's what netlink return and we seem to mostly return -EOPNOTSUPP
if the operation is completely not supported.
--
pw-bot: cr
next prev parent reply other threads:[~2023-06-07 3:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 18:46 [PATCH net-next] ethtool: ioctl: improve error checking for set_wol Justin Chen
2023-06-07 3:54 ` Jakub Kicinski [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-05-31 20:53 Justin Chen
2023-06-01 15:55 ` Simon Horman
2023-06-01 16:03 ` Jakub Kicinski
2023-06-01 16:23 ` Simon Horman
2023-06-01 16:23 ` Justin Chen
2023-06-01 16:22 ` Justin Chen
2023-06-01 18:27 ` Justin Chen
2023-06-01 18:37 ` Florian Fainelli
2023-06-01 18:48 ` Andrew Lunn
2023-06-01 18:58 ` Justin Chen
2023-06-01 20:41 ` Woojung.Huh
2023-06-02 8:54 ` Simon Horman
2023-06-05 18:21 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606205437.49378d25@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=d-tatianin@yandex-team.ru \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=jiri@resnulli.us \
--cc=justin.chen@broadcom.com \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=marco@mebeim.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sean.anderson@seco.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).