From: Jakub Kicinski <kuba@kernel.org>
To: <edward.cree@amd.com>
Cc: <linux-net-drivers@amd.com>, <davem@davemloft.net>,
<pabeni@redhat.com>, <edumazet@google.com>,
Edward Cree <ecree.xilinx@gmail.com>, <netdev@vger.kernel.org>,
<habetsm.xilinx@gmail.com>
Subject: Re: [PATCH net-next 5/6] sfc: neighbour lookup for TC encap action offload
Date: Tue, 6 Jun 2023 21:56:58 -0700 [thread overview]
Message-ID: <20230606215658.3192feec@kernel.org> (raw)
In-Reply-To: <286b3685eabf6cdd98021215b9b00020b442a42b.1685992503.git.ecree.xilinx@gmail.com>
On Mon, 5 Jun 2023 20:17:38 +0100 edward.cree@amd.com wrote:
> + dev_hold(neigh->egdev = dst->dev);
Please use the ref-tracker enabled helpers in new code.
And the assignment on a separate line, please.
next prev parent reply other threads:[~2023-06-07 4:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 19:17 [PATCH net-next 0/6] sfc: TC encap actions offload edward.cree
2023-06-05 19:17 ` [PATCH net-next 1/6] sfc: add fallback action-set-lists for TC offload edward.cree
2023-06-06 10:10 ` Pieter Jansen van Vuuren
2023-06-05 19:17 ` [PATCH net-next 2/6] sfc: some plumbing towards TC encap action offload edward.cree
2023-06-06 10:30 ` Pieter Jansen van Vuuren
2023-06-05 19:17 ` [PATCH net-next 3/6] sfc: add function to atomically update a rule in the MAE edward.cree
2023-06-06 10:32 ` Pieter Jansen van Vuuren
2023-06-05 19:17 ` [PATCH net-next 4/6] sfc: MAE functions to create/update/delete encap headers edward.cree
2023-06-06 10:44 ` Pieter Jansen van Vuuren
2023-06-05 19:17 ` [PATCH net-next 5/6] sfc: neighbour lookup for TC encap action offload edward.cree
2023-06-06 10:54 ` Pieter Jansen van Vuuren
2023-06-07 4:56 ` Jakub Kicinski [this message]
2023-06-07 20:51 ` Edward Cree
2023-06-07 23:00 ` Jakub Kicinski
2023-06-07 8:34 ` Simon Horman
2023-06-05 19:17 ` [PATCH net-next 6/6] sfc: generate encap headers for TC offload edward.cree
2023-06-06 3:52 ` Hao Lan
2023-06-06 15:03 ` Edward Cree
2023-06-06 15:23 ` Hao Lan
2023-06-06 11:02 ` Pieter Jansen van Vuuren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606215658.3192feec@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=edward.cree@amd.com \
--cc=habetsm.xilinx@gmail.com \
--cc=linux-net-drivers@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).