From: Stephen Hemminger <stephen@networkplumber.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, David Ahern <dsahern@kernel.org>
Subject: Re: [PATCH iproute2-next] tc/taprio: print the offload xstats
Date: Wed, 7 Jun 2023 08:13:35 -0700 [thread overview]
Message-ID: <20230607081335.7b799b9c@hermes.local> (raw)
In-Reply-To: <20230607125441.3819767-1-vladimir.oltean@nxp.com>
On Wed, 7 Jun 2023 15:54:41 +0300
Vladimir Oltean <vladimir.oltean@nxp.com> wrote:
> +static int taprio_print_xstats(struct qdisc_util *qu, FILE *f,
> + struct rtattr *xstats)
> +{
> + struct rtattr *st[TCA_TAPRIO_OFFLOAD_STATS_MAX + 1], *nla;
> +
> + if (!xstats)
> + return 0;
> +
> + parse_rtattr_nested(st, TCA_TAPRIO_OFFLOAD_STATS_MAX, xstats);
> +
> + nla = st[TCA_TAPRIO_OFFLOAD_STATS_WINDOW_DROPS];
> + if (nla)
> + print_lluint(PRINT_ANY, "window-drops", " Window drops: %llu",
> + rta_getattr_u64(nla));
> +
> + nla = st[TCA_TAPRIO_OFFLOAD_STATS_TX_OVERRUNS];
> + if (nla)
> + print_lluint(PRINT_ANY, "tx-overruns", " Transmit overruns: %llu",
> + rta_getattr_u64(nla));
> +
Ok, but the choice of wording here is off. It makes taprio stats different
in style than other qdisc. The convention in other qdisc is not to use upper case,
and use a one word key.
In other words, not "window-drops", " Window drops: %llu" but instead
"window_drops", " window_drops %llu",
next prev parent reply other threads:[~2023-06-07 15:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 12:54 [PATCH iproute2-next] tc/taprio: print the offload xstats Vladimir Oltean
2023-06-07 15:13 ` Stephen Hemminger [this message]
2023-06-07 15:33 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230607081335.7b799b9c@hermes.local \
--to=stephen@networkplumber.org \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).