From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3047963B5
	for <netdev@vger.kernel.org>; Wed,  7 Jun 2023 16:56:45 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9642C433EF;
	Wed,  7 Jun 2023 16:56:44 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1686157005;
	bh=aPvBZetYhuElDrsk7XgaTFNO0pGltg6x0ZotRqSwJPw=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=Inki/nRUfVwANPsVcJ1lXwPjALjzfm1hJuhTUtyxbCdDVKiA6DT2hysaQq7YRArkY
	 TmcAYk6xx2FxD6ZvT/LxBhyATpqVWXVwoXsxT4L3Fk+VS7tXb7l+Ezz8YYFYq8q3oN
	 2VLd8kilvOMvEceRci0tIwOEfxF6ZWhZW6zJpebJLwpnoIu63ZhnwNcgUWuTFd3ibp
	 L0MsVZNJ93F5rs2zGgKC/I5saeGGpHAMmCqleqjKHOf2+M7fX4kNpTZjTklqey4w1L
	 GcKK0AbFASSEzR05VPsh1SBNgSFAMsHKsDl80TScNufOJ8BAovXa75T/RLI6PZf2dS
	 ame/Hiq/DI6ow==
Date: Wed, 7 Jun 2023 09:56:43 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: David Howells <dhowells@redhat.com>
Cc: netdev@vger.kernel.org, Linus Torvalds <torvalds@linux-foundation.org>,
 Chuck Lever <chuck.lever@oracle.com>, Boris Pismenny <borisp@nvidia.com>,
 John Fastabend <john.fastabend@gmail.com>, "David S. Miller"
 <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Paolo Abeni
 <pabeni@redhat.com>, Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
 David Ahern <dsahern@kernel.org>, Matthew Wilcox <willy@infradead.org>,
 Jens Axboe <axboe@kernel.dk>, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>, Al Viro
 <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>, Jeff Layton
 <jlayton@kernel.org>, David Hildenbrand <david@redhat.com>, Christian
 Brauner <brauner@kernel.org>, linux-fsdevel@vger.kernel.org,
 linux-block@vger.kernel.org
Subject: Re: [PATCH net-next v5 04/14] splice, net: Add a splice_eof op to
 file-ops and socket-ops
Message-ID: <20230607095643.38c18ef6@kernel.org>
In-Reply-To: <20230607140559.2263470-5-dhowells@redhat.com>
References: <20230607140559.2263470-1-dhowells@redhat.com>
	<20230607140559.2263470-5-dhowells@redhat.com>
Precedence: bulk
X-Mailing-List: netdev@vger.kernel.org
List-Id: <netdev.vger.kernel.org>
List-Subscribe: <mailto:netdev+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:netdev+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed,  7 Jun 2023 15:05:49 +0100 David Howells wrote:
> Add an optional method, ->splice_eof(), to allow splice to indicate the
> premature termination of a splice to struct file_operations and struct
> proto_ops.
> 
> This is called if sendfile() or splice() encounters all of the following
> conditions inside splice_direct_to_actor():
> 
>  (1) the user did not set SPLICE_F_MORE (splice only), and
> 
>  (2) an EOF condition occurred (->splice_read() returned 0), and
> 
>  (3) we haven't read enough to fulfill the request (ie. len > 0 still), and
> 
>  (4) we have already spliced at least one byte.
> 
> A further patch will modify the behaviour of SPLICE_F_MORE to always be
> passed to the actor if either the user set it or we haven't yet read
> sufficient data to fulfill the request.

Reviewed-by: Jakub Kicinski <kuba@kernel.org>