From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Jeffrey Hugo <quic_jhugo@quicinc.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, mhi@lists.linux.dev,
linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, loic.poulain@linaro.org
Subject: Re: [PATCH 3/3] net: mhi: Increase the default MTU from 16K to 32K
Date: Wed, 7 Jun 2023 20:26:37 +0530 [thread overview]
Message-ID: <20230607145637.GA103098@thinkpad> (raw)
In-Reply-To: <f96d4956-6b69-4809-9461-9157e32b3865@lunn.ch>
On Wed, Jun 07, 2023 at 02:25:50PM +0200, Andrew Lunn wrote:
> On Wed, Jun 07, 2023 at 12:28:09PM +0530, Manivannan Sadhasivam wrote:
> > On Tue, Jun 06, 2023 at 07:50:23AM -0600, Jeffrey Hugo wrote:
> > > On 6/6/2023 6:31 AM, Manivannan Sadhasivam wrote:
> > > > Most of the Qualcomm endpoint devices are supporting 32K MTU for the
> > > > UL (Uplink) and DL (Downlink) channels. So let's use the same value
> > > > in the MHI NET driver also. This gives almost 2x increase in the throughput
> > > > for the UL channel.
>
> You say here 'Most'. What happens on those which do not support 32K?
> Do the packets get dropped and it turns into a black hole?
>
Yeah, and the host has to retransmit. But I checked again with Qcom on the MTU
size and got a different answer that forced me to change "most" to "few". So
this patch is not needed for now. I'll drop it.
- Mani
> Andrew
>
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2023-06-07 14:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 12:31 [PATCH 0/3] Add MHI Endpoint network driver Manivannan Sadhasivam
2023-06-06 12:31 ` [PATCH 1/3] net: " Manivannan Sadhasivam
2023-06-07 8:20 ` Simon Horman
2023-06-07 11:21 ` Manivannan Sadhasivam
2023-06-06 12:31 ` [PATCH 2/3] MAINTAINERS: Add entry for MHI networking drivers under MHI bus Manivannan Sadhasivam
2023-06-06 12:31 ` [PATCH 3/3] net: mhi: Increase the default MTU from 16K to 32K Manivannan Sadhasivam
2023-06-06 13:50 ` Jeffrey Hugo
2023-06-07 6:58 ` Manivannan Sadhasivam
2023-06-07 12:25 ` Andrew Lunn
2023-06-07 14:56 ` Manivannan Sadhasivam [this message]
2023-06-07 8:21 ` Simon Horman
2023-06-06 12:59 ` [PATCH 0/3] Add MHI Endpoint network driver Andrew Lunn
2023-06-07 6:56 ` Manivannan Sadhasivam
2023-06-07 7:12 ` Loic Poulain
2023-06-07 7:41 ` Manivannan Sadhasivam
2023-06-07 12:28 ` Andrew Lunn
2023-06-07 14:19 ` Jeffrey Hugo
2023-06-06 21:22 ` Jakub Kicinski
2023-06-07 7:03 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230607145637.GA103098@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mhi@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_jhugo@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).