* [PATCH v1 4/8] dt-bindings: can: m_can: add termination-{gpios,ohms} properties [not found] <20230607115508.2964574-1-l.goehrs@pengutronix.de> @ 2023-06-07 11:55 ` Leonard Göhrs 2023-06-07 17:51 ` Conor Dooley 2023-06-07 23:03 ` Rob Herring 2023-06-07 11:55 ` [PATCH v1 5/8] dt-bindings: net: dsa: microchip: add missing spi-{cpha,cpol} properties Leonard Göhrs 1 sibling, 2 replies; 6+ messages in thread From: Leonard Göhrs @ 2023-06-07 11:55 UTC (permalink / raw) To: Chandrasekar Ramakrishnan, Wolfgang Grandegger, Marc Kleine-Budde, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni Cc: kernel, Leonard Göhrs, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-can, netdev, devicetree, linux-kernel The termination-gpios property allows specifying a GPIO pin that enables/disables a termination resistor on said CAN interface. The termination-ohms property specifies the resistance of said resistor. Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de> --- Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml index 67879aab623b5..106c79fa560c3 100644 --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml @@ -118,6 +118,9 @@ properties: phys: maxItems: 1 + termination-gpios: true + termination-ohms: true + required: - compatible - reg -- 2.39.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v1 4/8] dt-bindings: can: m_can: add termination-{gpios,ohms} properties 2023-06-07 11:55 ` [PATCH v1 4/8] dt-bindings: can: m_can: add termination-{gpios,ohms} properties Leonard Göhrs @ 2023-06-07 17:51 ` Conor Dooley 2023-06-07 23:03 ` Rob Herring 1 sibling, 0 replies; 6+ messages in thread From: Conor Dooley @ 2023-06-07 17:51 UTC (permalink / raw) To: Leonard Göhrs Cc: Chandrasekar Ramakrishnan, Wolfgang Grandegger, Marc Kleine-Budde, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, kernel, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-can, netdev, devicetree, linux-kernel [-- Attachment #1: Type: text/plain, Size: 410 bytes --] On Wed, Jun 07, 2023 at 01:55:03PM +0200, Leonard Göhrs wrote: > The termination-gpios property allows specifying a GPIO pin that > enables/disables a termination resistor on said CAN interface. > The termination-ohms property specifies the resistance of said resistor. > > Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de> Acked-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 4/8] dt-bindings: can: m_can: add termination-{gpios,ohms} properties 2023-06-07 11:55 ` [PATCH v1 4/8] dt-bindings: can: m_can: add termination-{gpios,ohms} properties Leonard Göhrs 2023-06-07 17:51 ` Conor Dooley @ 2023-06-07 23:03 ` Rob Herring 1 sibling, 0 replies; 6+ messages in thread From: Rob Herring @ 2023-06-07 23:03 UTC (permalink / raw) To: Leonard Göhrs Cc: Chandrasekar Ramakrishnan, Wolfgang Grandegger, Marc Kleine-Budde, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, kernel, Krzysztof Kozlowski, Conor Dooley, linux-can, netdev, devicetree, linux-kernel On Wed, Jun 07, 2023 at 01:55:03PM +0200, Leonard Göhrs wrote: > The termination-gpios property allows specifying a GPIO pin that > enables/disables a termination resistor on said CAN interface. > The termination-ohms property specifies the resistance of said resistor. > > Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de> > --- > Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml > index 67879aab623b5..106c79fa560c3 100644 > --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml > +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml > @@ -118,6 +118,9 @@ properties: > phys: > maxItems: 1 > > + termination-gpios: true > + termination-ohms: true All you should need here is change additionalProperties to unevaluatedProperties as these are defined by can-controller.yaml. > + > required: > - compatible > - reg > -- > 2.39.2 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1 5/8] dt-bindings: net: dsa: microchip: add missing spi-{cpha,cpol} properties [not found] <20230607115508.2964574-1-l.goehrs@pengutronix.de> 2023-06-07 11:55 ` [PATCH v1 4/8] dt-bindings: can: m_can: add termination-{gpios,ohms} properties Leonard Göhrs @ 2023-06-07 11:55 ` Leonard Göhrs 2023-06-07 17:50 ` Conor Dooley 2023-06-07 23:04 ` Rob Herring 1 sibling, 2 replies; 6+ messages in thread From: Leonard Göhrs @ 2023-06-07 11:55 UTC (permalink / raw) To: Woojung Huh, UNGLinuxDriver, Andrew Lunn, Florian Fainelli, Vladimir Oltean, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Marek Vasut Cc: kernel, Leonard Göhrs, Rob Herring, Krzysztof Kozlowski, Conor Dooley, netdev, devicetree, linux-kernel This patch allows setting the correct SPI phase and polarity for KSZ switches. Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de> --- Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml index e51be1ac03623..f7c620d9ee8b4 100644 --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml @@ -49,6 +49,9 @@ properties: Set if the output SYNCLKO clock should be disabled. Do not mix with microchip,synclko-125. + spi-cpha: true + spi-cpol: true + required: - compatible - reg -- 2.39.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v1 5/8] dt-bindings: net: dsa: microchip: add missing spi-{cpha,cpol} properties 2023-06-07 11:55 ` [PATCH v1 5/8] dt-bindings: net: dsa: microchip: add missing spi-{cpha,cpol} properties Leonard Göhrs @ 2023-06-07 17:50 ` Conor Dooley 2023-06-07 23:04 ` Rob Herring 1 sibling, 0 replies; 6+ messages in thread From: Conor Dooley @ 2023-06-07 17:50 UTC (permalink / raw) To: Leonard Göhrs Cc: Woojung Huh, UNGLinuxDriver, Andrew Lunn, Florian Fainelli, Vladimir Oltean, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Marek Vasut, kernel, Rob Herring, Krzysztof Kozlowski, Conor Dooley, netdev, devicetree, linux-kernel [-- Attachment #1: Type: text/plain, Size: 285 bytes --] On Wed, Jun 07, 2023 at 01:55:04PM +0200, Leonard Göhrs wrote: > This patch allows setting the correct SPI phase and polarity for KSZ > switches. > > Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de> Acked-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 5/8] dt-bindings: net: dsa: microchip: add missing spi-{cpha,cpol} properties 2023-06-07 11:55 ` [PATCH v1 5/8] dt-bindings: net: dsa: microchip: add missing spi-{cpha,cpol} properties Leonard Göhrs 2023-06-07 17:50 ` Conor Dooley @ 2023-06-07 23:04 ` Rob Herring 1 sibling, 0 replies; 6+ messages in thread From: Rob Herring @ 2023-06-07 23:04 UTC (permalink / raw) To: Leonard Göhrs Cc: Woojung Huh, UNGLinuxDriver, Andrew Lunn, Florian Fainelli, Vladimir Oltean, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Marek Vasut, kernel, Krzysztof Kozlowski, Conor Dooley, netdev, devicetree, linux-kernel On Wed, Jun 07, 2023 at 01:55:04PM +0200, Leonard Göhrs wrote: > This patch allows setting the correct SPI phase and polarity for KSZ > switches. > > Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de> > --- > Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml > index e51be1ac03623..f7c620d9ee8b4 100644 > --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml > @@ -49,6 +49,9 @@ properties: > Set if the output SYNCLKO clock should be disabled. Do not mix with > microchip,synclko-125. > > + spi-cpha: true > + spi-cpol: true These should only be needed if the mode is configurable or variable. Otherwise, the driver for the device should set the mode correctly. Rob ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-06-07 23:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230607115508.2964574-1-l.goehrs@pengutronix.de>
2023-06-07 11:55 ` [PATCH v1 4/8] dt-bindings: can: m_can: add termination-{gpios,ohms} properties Leonard Göhrs
2023-06-07 17:51 ` Conor Dooley
2023-06-07 23:03 ` Rob Herring
2023-06-07 11:55 ` [PATCH v1 5/8] dt-bindings: net: dsa: microchip: add missing spi-{cpha,cpol} properties Leonard Göhrs
2023-06-07 17:50 ` Conor Dooley
2023-06-07 23:04 ` Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).