From: Jakub Kicinski <kuba@kernel.org>
To: Pedro Tammela <pctammela@mojatatu.com>
Cc: netdev@vger.kernel.org, tgraf@suug.ch,
herbert@gondor.apana.org.au, davem@davemloft.net,
dsahern@kernel.org, edumazet@google.com, pabeni@redhat.com
Subject: Re: [RFC PATCH net-next 0/4] rhashtable: length helper for rhashtable and rhltable
Date: Fri, 9 Jun 2023 10:36:44 -0700 [thread overview]
Message-ID: <20230609103644.7bdd3873@kernel.org> (raw)
In-Reply-To: <20230609151332.263152-1-pctammela@mojatatu.com>
On Fri, 9 Jun 2023 12:13:28 -0300 Pedro Tammela wrote:
> Whenever someone wants to retrieve the total number of elements in a
> rhashtable/rhltable it needs to open code the access to 'nelems'.
> Therefore provide a helper for such operation and convert two accesses as
> an example.
IMHO read of nelems is much more readable than len(). I mean the name
of the helper is not great. IDK what length of a hashtable is. Feels
like a Python-ism.
next prev parent reply other threads:[~2023-06-09 17:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 15:13 [RFC PATCH net-next 0/4] rhashtable: length helper for rhashtable and rhltable Pedro Tammela
2023-06-09 15:13 ` [RFC PATCH net-next 1/4] rhashtable: add " Pedro Tammela
2023-06-09 15:22 ` Eric Dumazet
2023-06-09 15:13 ` [RFC PATCH net-next 2/4] rhashtable: use new length helpers Pedro Tammela
2023-06-09 15:13 ` [RFC PATCH net-next 3/4] net/ipv4: use rhashtable length helper Pedro Tammela
2023-06-09 15:13 ` [RFC PATCH net-next 4/4] net/ipv6: " Pedro Tammela
2023-06-09 17:36 ` Jakub Kicinski [this message]
2023-06-09 18:13 ` [RFC PATCH net-next 0/4] rhashtable: length helper for rhashtable and rhltable Pedro Tammela
2023-06-09 18:21 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230609103644.7bdd3873@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pctammela@mojatatu.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).