From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF3B323D77 for ; Fri, 9 Jun 2023 21:43:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44A3CC433A8; Fri, 9 Jun 2023 21:43:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686347038; bh=Nu+UgcticBmAXjUwDdlmC6YgZXHtSrweKH3jl8QoXI0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hHRtcuRcFUPZ0Zizv64xGwpgfAmpDJJGfGHastsJOG5w+8Z07I0iYinL0mqDGx/jk PxCoAeBJHpiBs9xHwtpPVhdHED4aqk5WRx0wYRSfLDreOfW+QNjBDJc+RzPmNt8R+6 DTcBeen2PVbejPpWe7A/cHL0FOJCteAc+Vg7Ky1/W6UBQ9HPgTo+NbqwxJEm2gd6Gh zoLaMvQZ4ut0d6Ir7Iy19t0ffMC5TPdZOeiNHRYO+Kb0N4cqQ2bFJ4WbyqGcloGOqd 68zjQDgHxD8X8mZVu8ybVISuGOS2up4cqRUC6bpbOL1hR+a7irIqeb6Ho6ghYAADiU xdpF6IbmTFgnA== From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, sdf@google.com, Jakub Kicinski Subject: [PATCH net-next 09/12] netlink: specs: ethtool: untangle stats-get Date: Fri, 9 Jun 2023 14:43:43 -0700 Message-Id: <20230609214346.1605106-10-kuba@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230609214346.1605106-1-kuba@kernel.org> References: <20230609214346.1605106-1-kuba@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Code gen for stats is a bit of a challenge, but from looking at the attrs I think that the format isn't quite right. Signed-off-by: Jakub Kicinski --- Documentation/netlink/specs/ethtool.yaml | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml index 17b7b5028e2b..00c1ab04b857 100644 --- a/Documentation/netlink/specs/ethtool.yaml +++ b/Documentation/netlink/specs/ethtool.yaml @@ -793,16 +793,29 @@ doc: Partial family for Ethtool Netlink. type: u32 - name: stat - type: nest - nested-attributes: u64 + type: u64 + type-value: [ id ] - name: hist-rx type: nest - nested-attributes: u64 + nested-attributes: stats-grp-hist - name: hist-tx type: nest - nested-attributes: u64 + nested-attributes: stats-grp-hist + - + name: hist-bkt-low + type: u32 + - + name: hist-bkt-hi + type: u32 + - + name: hist-val + type: u64 + - + name: stats-grp-hist + subset-of: stats-grp + attributes: - name: hist-bkt-low type: u32 -- 2.40.1