From: Jakub Kicinski <kuba@kernel.org>
To: Justin Chen <justin.chen@broadcom.com>
Cc: netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
florian.fainelli@broadcom.com,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
Daniil Tatianin <d-tatianin@yandex-team.ru>,
Ido Schimmel <idosch@nvidia.com>,
Marco Bonelli <marco@mebeim.net>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Jiri Pirko <jiri@resnulli.us>, Gal Pressman <gal@nvidia.com>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 net-next] ethtool: ioctl: improve error checking for set_wol
Date: Fri, 9 Jun 2023 23:18:43 -0700 [thread overview]
Message-ID: <20230609231843.6e5a18db@kernel.org> (raw)
In-Reply-To: <c512a8ee-cfc7-d0c8-6cf2-442da8dc1f1b@broadcom.com>
On Fri, 9 Jun 2023 13:47:22 -0700 Justin Chen wrote:
> Was thinking more about this patch. I realized we don't account for the
> different sopass case.
> # ethtool -s eth0 wol s sopass 11:22:33:44:55:66
> # ethtool -s eth0 wol s sopass 22:44:55:66:77:88
>
> For this case, the second sopass values won't be stored.
>
> Can you drop this patch? I will submit another version.
We can't drop patches, it'd mess up commit IDs and basing
trees on top of net-next would be a major PITA for people.
Please send a fix on top (with a Fixes tag making it clear
that the problem has not reached any -rc kernel).
prev parent reply other threads:[~2023-06-10 6:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 23:14 [PATCH v2 net-next] ethtool: ioctl: improve error checking for set_wol Justin Chen
2023-06-08 16:01 ` Florian Fainelli
2023-06-09 2:40 ` patchwork-bot+netdevbpf
2023-06-09 20:47 ` Justin Chen
2023-06-10 6:18 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230609231843.6e5a18db@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=d-tatianin@yandex-team.ru \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=gal@nvidia.com \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=justin.chen@broadcom.com \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=marco@mebeim.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).