From: Ido Schimmel <idosch@nvidia.com>
To: <netdev@vger.kernel.org>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>,
<edumazet@google.com>, <razor@blackwall.org>, <petrm@nvidia.com>,
"Ido Schimmel" <idosch@nvidia.com>
Subject: [PATCH net-next] selftests: forwarding: Fix layer 2 miss test syntax
Date: Sun, 11 Jun 2023 14:22:18 +0300 [thread overview]
Message-ID: <20230611112218.332298-1-idosch@nvidia.com> (raw)
The test currently specifies "l2_miss" as "true" / "false", but the
version that eventually landed in iproute2 uses "1" / "0" [1]. Align the
test accordingly.
[1] https://lore.kernel.org/netdev/20230607153550.3829340-1-idosch@nvidia.com/
Fixes: 8c33266ae26a ("selftests: forwarding: Add layer 2 miss test cases")
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
.../selftests/net/forwarding/tc_flower_l2_miss.sh | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/tools/testing/selftests/net/forwarding/tc_flower_l2_miss.sh b/tools/testing/selftests/net/forwarding/tc_flower_l2_miss.sh
index 37b0369b5246..e22c2d28b6eb 100755
--- a/tools/testing/selftests/net/forwarding/tc_flower_l2_miss.sh
+++ b/tools/testing/selftests/net/forwarding/tc_flower_l2_miss.sh
@@ -78,11 +78,11 @@ test_l2_miss_unicast()
# Unknown unicast.
tc filter add dev $swp2 egress protocol ipv4 handle 101 pref 1 \
- flower indev $swp1 l2_miss true dst_mac $dmac src_ip $sip \
+ flower indev $swp1 l2_miss 1 dst_mac $dmac src_ip $sip \
dst_ip $dip action pass
# Known unicast.
tc filter add dev $swp2 egress protocol ipv4 handle 102 pref 1 \
- flower indev $swp1 l2_miss false dst_mac $dmac src_ip $sip \
+ flower indev $swp1 l2_miss 0 dst_mac $dmac src_ip $sip \
dst_ip $dip action pass
# Before adding FDB entry.
@@ -134,11 +134,11 @@ test_l2_miss_multicast_common()
# Unregistered multicast.
tc filter add dev $swp2 egress protocol $proto handle 101 pref 1 \
- flower indev $swp1 l2_miss true src_ip $sip dst_ip $dip \
+ flower indev $swp1 l2_miss 1 src_ip $sip dst_ip $dip \
action pass
# Registered multicast.
tc filter add dev $swp2 egress protocol $proto handle 102 pref 1 \
- flower indev $swp1 l2_miss false src_ip $sip dst_ip $dip \
+ flower indev $swp1 l2_miss 0 src_ip $sip dst_ip $dip \
action pass
# Before adding MDB entry.
@@ -245,7 +245,7 @@ test_l2_miss_ll_multicast_common()
RET=0
tc filter add dev $swp2 egress protocol $proto handle 101 pref 1 \
- flower indev $swp1 l2_miss true dst_mac $dmac src_ip $sip \
+ flower indev $swp1 l2_miss 1 dst_mac $dmac src_ip $sip \
dst_ip $dip action pass
$MZ $mode $h1 -a own -b $dmac -t ip -A $sip -B $dip -c 1 -p 100 -q
@@ -296,10 +296,10 @@ test_l2_miss_broadcast()
RET=0
tc filter add dev $swp2 egress protocol all handle 101 pref 1 \
- flower l2_miss true dst_mac $dmac src_mac $smac \
+ flower l2_miss 1 dst_mac $dmac src_mac $smac \
action pass
tc filter add dev $swp2 egress protocol all handle 102 pref 1 \
- flower l2_miss false dst_mac $dmac src_mac $smac \
+ flower l2_miss 0 dst_mac $dmac src_mac $smac \
action pass
$MZ $h1 -a $smac -b $dmac -c 1 -p 100 -q
--
2.40.1
next reply other threads:[~2023-06-11 11:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-11 11:22 Ido Schimmel [this message]
2023-06-12 6:15 ` [PATCH net-next] selftests: forwarding: Fix layer 2 miss test syntax Petr Machata
2023-06-13 8:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230611112218.332298-1-idosch@nvidia.com \
--to=idosch@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).