From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCH 2/4] net/tls: handle MSG_EOR for tls_device TX flow
Date: Mon, 12 Jun 2023 16:38:31 +0200 [thread overview]
Message-ID: <20230612143833.70805-3-hare@suse.de> (raw)
In-Reply-To: <20230612143833.70805-1-hare@suse.de>
tls_push_data() MSG_MORE / MSG_SENDPAGE_NOTLAST, but bails
out on MSG_EOR.
But seeing that MSG_EOR is basically the opposite of
MSG_MORE / MSG_SENDPAGE_NOTLAST this patch adds handling
MSG_EOR by treating it as the absence of MSG_MORE.
Consequently we should return an error when both are set.
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
net/tls/tls_device.c | 24 ++++++++++++++++++++----
1 file changed, 20 insertions(+), 4 deletions(-)
diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c
index a7cc4f9faac2..0024febd40de 100644
--- a/net/tls/tls_device.c
+++ b/net/tls/tls_device.c
@@ -448,10 +448,6 @@ static int tls_push_data(struct sock *sk,
int copy, rc = 0;
long timeo;
- if (flags &
- ~(MSG_MORE | MSG_DONTWAIT | MSG_NOSIGNAL | MSG_SENDPAGE_NOTLAST))
- return -EOPNOTSUPP;
-
if (unlikely(sk->sk_err))
return -sk->sk_err;
@@ -529,6 +525,10 @@ static int tls_push_data(struct sock *sk,
more = true;
break;
}
+ if (flags & MSG_EOR) {
+ more = false;
+ break;
+ }
done = true;
}
@@ -573,6 +573,14 @@ int tls_device_sendmsg(struct sock *sk, struct msghdr *msg, size_t size)
union tls_iter_offset iter;
int rc;
+ if (msg->msg_flags &
+ ~(MSG_MORE | MSG_DONTWAIT | MSG_NOSIGNAL | MSG_EOR))
+ return -EOPNOTSUPP;
+
+ if ((msg->msg_flags & MSG_MORE) &&
+ (msg->msg_flags & MSG_EOR))
+ return -EOPNOTSUPP;
+
mutex_lock(&tls_ctx->tx_lock);
lock_sock(sk);
@@ -601,9 +609,17 @@ int tls_device_sendpage(struct sock *sk, struct page *page,
struct kvec iov;
int rc;
+ if (flags &
+ ~(MSG_MORE | MSG_DONTWAIT | MSG_NOSIGNAL | MSG_SENDPAGE_NOTLAST | MSG_EOR))
+ return -EOPNOTSUPP;
+
if (flags & MSG_SENDPAGE_NOTLAST)
flags |= MSG_MORE;
+ if ((flags & MSG_MORE) &&
+ (flags & MSG_EOR))
+ return -EOPNOTSUPP;
+
mutex_lock(&tls_ctx->tx_lock);
lock_sock(sk);
--
2.35.3
next prev parent reply other threads:[~2023-06-12 14:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 14:38 [PATCHv3 0/4] net/tls: fixes for NVMe-over-TLS Hannes Reinecke
2023-06-12 14:38 ` [PATCH 1/4] net/tls: handle MSG_EOR for tls_sw TX flow Hannes Reinecke
2023-06-12 14:38 ` Hannes Reinecke [this message]
2023-06-13 7:58 ` [PATCH 2/4] net/tls: handle MSG_EOR for tls_device " Sagi Grimberg
2023-06-13 8:11 ` Hannes Reinecke
2023-06-13 16:59 ` Jakub Kicinski
2023-06-12 14:38 ` [PATCH 3/4] net/tls: implement ->read_sock() Hannes Reinecke
2023-06-12 14:38 ` [PATCH 4/4] selftests/net/tls: add test for MSG_EOR Hannes Reinecke
-- strict thread matches above, loose matches on Subject: below --
2023-06-20 10:28 [PATCHv5 0/4] net/tls: fixes for NVMe-over-TLS Hannes Reinecke
2023-06-20 10:28 ` [PATCH 2/4] net/tls: handle MSG_EOR for tls_device TX flow Hannes Reinecke
2023-06-20 17:12 ` Sabrina Dubroca
2023-06-21 6:09 ` Hannes Reinecke
2023-06-14 6:22 [PATCHv4 0/4] net/tls: fixes for NVMe-over-TLS Hannes Reinecke
2023-06-14 6:22 ` [PATCH 2/4] net/tls: handle MSG_EOR for tls_device TX flow Hannes Reinecke
2023-06-09 12:51 [PATCHv2 0/4] net/tls: fixes for NVMe-over-TLS Hannes Reinecke
2023-06-09 12:51 ` [PATCH 2/4] net/tls: handle MSG_EOR for tls_device TX flow Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230612143833.70805-3-hare@suse.de \
--to=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).