From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A75920F1 for ; Mon, 12 Jun 2023 18:34:50 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED9BAE73 for ; Mon, 12 Jun 2023 11:34:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686594878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fA7PgHsHXUvTzj6r/c+oFo9WuyCUMyzAZAoI7rpa/bU=; b=G9ICo0tqXtxlhmkXu8WG8mnr6oZ35IMGnPsHWVfJZyUYYBTbkK75bGLe203hSFzn6fZhxA W5duos/D5hIeAfW5dY32Bsiw6KC+ad6qp2O1PLzU/lSvOMQJzj6tnoEggVqepK1vuPacuk hsx+TwBoQrdiW4Yp92taQelhmvrTAaU= Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-470-ZFPkCN9uOD-GDq42l7hZIA-1; Mon, 12 Jun 2023 14:34:37 -0400 X-MC-Unique: ZFPkCN9uOD-GDq42l7hZIA-1 Received: by mail-ot1-f72.google.com with SMTP id 46e09a7af769-6b2bf00f660so3211650a34.3 for ; Mon, 12 Jun 2023 11:34:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686594877; x=1689186877; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fA7PgHsHXUvTzj6r/c+oFo9WuyCUMyzAZAoI7rpa/bU=; b=FQTII1eNrQBRmkixooJwVYXzr02qwZnFfAkhNZxlbYOWuUbVMiY8QPeKK547b8nWok AMuSShstZKqpJQ4/aPx/nC1dV+SGm5YLGKfLYzKZQnFTlJKK0A7JGw6TofeMvLaIweKS 4ieSul6FJ1iVue+3V4gHaTjsFXyhrNydYdIikX67yFNq7UJ5O9RQZckhjJEGaDo/UuY6 GkKahHVX+Ns1vY0dnApnioAZPeS7NsXTbJyfNYDP6Dc4baXqNhIodmP3H6v1oURyn0NB 3qlkVMkvnzRTIspqqDZSrCRed+3kAIkBdSQvhaddeuI48spEQ+PQit7BMLqgEYOaT8kO 4lwA== X-Gm-Message-State: AC+VfDwTgmU/FTLpFdXhCVxRSCc12Ya/4VlPGPwySWZ897E2TinL1fhv Kvs2+16/oLtWSq72AeVPATSC/3EEoTEVrWLw5hWclSH+cdsuYIQUIcCrCmyG0cWcYPTNSGE9kdc nV+x/9Kut+mp9cvb1 X-Received: by 2002:a9d:6299:0:b0:6b2:b82c:1418 with SMTP id x25-20020a9d6299000000b006b2b82c1418mr6159653otk.9.1686594876850; Mon, 12 Jun 2023 11:34:36 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ71QwPMhZSycXjuAG8mCHe8g88dFSFJqGDZsnw2ZprTbOlJNax+lvJcUSmy8K0z+ff8r52HsQ== X-Received: by 2002:a9d:6299:0:b0:6b2:b82c:1418 with SMTP id x25-20020a9d6299000000b006b2b82c1418mr6159634otk.9.1686594876618; Mon, 12 Jun 2023 11:34:36 -0700 (PDT) Received: from halaney-x13s ([2600:1700:1ff0:d0e0::45]) by smtp.gmail.com with ESMTPSA id q21-20020a056830019500b006b2a31ec95dsm4137128ota.65.2023.06.12.11.34.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 11:34:36 -0700 (PDT) Date: Mon, 12 Jun 2023 13:34:33 -0500 From: Andrew Halaney To: Bartosz Golaszewski Cc: Vinod Koul , Bhupesh Sharma , Andy Gross , Bjorn Andersson , Konrad Dybcio , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kishon Vijay Abraham I , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Bartosz Golaszewski Subject: Re: [PATCH 07/26] net: stmmac: dwmac-qcom-ethqos: tweak the order of local variables Message-ID: <20230612183433.ii23wc2yie5n25vs@halaney-x13s> References: <20230612092355.87937-1-brgl@bgdev.pl> <20230612092355.87937-8-brgl@bgdev.pl> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612092355.87937-8-brgl@bgdev.pl> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Mon, Jun 12, 2023 at 11:23:36AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Make sure we follow the reverse-xmas tree convention. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Andrew Halaney > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > index 16e856861558..28d2514a8795 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > @@ -594,9 +594,9 @@ static void ethqos_clks_disable(void *data) > static int qcom_ethqos_probe(struct platform_device *pdev) > { > struct device_node *np = pdev->dev.of_node; > + const struct ethqos_emac_driver_data *data; > struct plat_stmmacenet_data *plat_dat; > struct stmmac_resources stmmac_res; > - const struct ethqos_emac_driver_data *data; > struct qcom_ethqos *ethqos; > int ret; > > -- > 2.39.2 >