From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C6932108D for ; Mon, 12 Jun 2023 21:06:40 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0794C1709 for ; Mon, 12 Jun 2023 14:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686603998; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UVvZ3v/vxKNyCI7w7GwLJIJ0X+T6wDAbj+0uoM6y2a8=; b=hevaT2moI9QTk5ON+SkwNEGYqUGrm4A0poCMTULGdCdAgFsXXUgf5tz76ntTmzcYaQiYDf Ly0epKZCmNroh3996M4dtlwocX7KkAUng1KlHmIqSWiTs+lqD0ggM0MwEMbmY/3iTqu9vZ G3qhecMOCHXZxvNqAbCH4BRA5/6W0dQ= Received: from mail-oa1-f72.google.com (mail-oa1-f72.google.com [209.85.160.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-Ql_hZhyqMdiFYxvKtlHrcQ-1; Mon, 12 Jun 2023 17:06:36 -0400 X-MC-Unique: Ql_hZhyqMdiFYxvKtlHrcQ-1 Received: by mail-oa1-f72.google.com with SMTP id 586e51a60fabf-1a316a3929bso3164102fac.1 for ; Mon, 12 Jun 2023 14:06:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686603996; x=1689195996; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UVvZ3v/vxKNyCI7w7GwLJIJ0X+T6wDAbj+0uoM6y2a8=; b=TNht00EheXVIV7plPnQ1sacqVy60eacnSnP4CMrfBWR4MLMrojVRRQuNKGmdiQpLe4 spnrLFxlrnXb1uJv2mAzUy5aCMT3eBmF8lvV2faMYtCklcNN4cUVKioCnDN4VZrIC3yo 0LjQMuodGU7KFjGqQT9fps5coj2NqV9zIo/el0/rx5OlI1libnMQZuRARgJqdge6lzJJ JR/nHb6HZQfTiBwWTVVpVUJ8sQX/lPl1VdBy0lnLZw/cbzkyTbB1/aSFR4iNjt+4uyvY 1SrwHAGdYnSH3oIzOaROAGOl8iqVr60ocrFBkWOI5EAjofyWoLVVbF/WNnrdX6zfqm4Z ewpw== X-Gm-Message-State: AC+VfDx/o2E4iXb4mH4qUu24WPrKLR3YhaJKMIL4WwicCzt0IRP7F8nz yRlRh9Vjd8FpAIZJi7pNcZICaVGAnm6LEdmLvK1v9nHjYlrDceI7QhaeqNDOB5370us/+J+TGu/ C6LYbUnet6MsSh0hC X-Received: by 2002:a05:6870:770d:b0:1a6:7ae5:8e31 with SMTP id dw13-20020a056870770d00b001a67ae58e31mr2707697oab.15.1686603996098; Mon, 12 Jun 2023 14:06:36 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5l8CIOc/fjbn/4dLBsqStqDJVa3ICb/fLC7IjnpwzGvy8FQcOZ753YVKUTI3PaLVSqB/0bAw== X-Received: by 2002:a05:6870:770d:b0:1a6:7ae5:8e31 with SMTP id dw13-20020a056870770d00b001a67ae58e31mr2707670oab.15.1686603995860; Mon, 12 Jun 2023 14:06:35 -0700 (PDT) Received: from halaney-x13s ([2600:1700:1ff0:d0e0::45]) by smtp.gmail.com with ESMTPSA id nw27-20020a056870bb1b00b001a6825ed5cfsm2251974oab.4.2023.06.12.14.06.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 14:06:35 -0700 (PDT) Date: Mon, 12 Jun 2023 16:06:32 -0500 From: Andrew Halaney To: Bartosz Golaszewski Cc: Vinod Koul , Bhupesh Sharma , Andy Gross , Bjorn Andersson , Konrad Dybcio , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kishon Vijay Abraham I , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Bartosz Golaszewski Subject: Re: [PATCH 15/26] net: stmmac: dwmac-qcom-ethqos: add support for the optional phy-supply Message-ID: <20230612210632.agp4ybeseujblao2@halaney-x13s> References: <20230612092355.87937-1-brgl@bgdev.pl> <20230612092355.87937-16-brgl@bgdev.pl> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612092355.87937-16-brgl@bgdev.pl> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Mon, Jun 12, 2023 at 11:23:44AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > On sa8775p-ride we need to enable the power supply for the external PHY. Is this for the external phy? It doesn't seem like it from the board schematic I have... the regulator never makes it out of the black box that is the SIP/SOM if I'm reading right. My (poor) understanding was this was for the serdes phy that's doing the conversion to SGMII before hitting the board... good chance I'm wrong though. > > Signed-off-by: Bartosz Golaszewski > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > index 2f6b9b419601..21f329d2f7eb 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > @@ -8,6 +8,7 @@ > #include > #include > #include > +#include > > #include "stmmac.h" > #include "stmmac_platform.h" > @@ -692,6 +693,10 @@ static int qcom_ethqos_probe(struct platform_device *pdev) > if (ret) > goto out_config_dt; > > + ret = devm_regulator_get_enable_optional(dev, "phy"); > + if (ret < 0 && ret != -ENODEV) > + goto out_config_dt; > + > ethqos->serdes_phy = devm_phy_optional_get(dev, "serdes"); > if (IS_ERR(ethqos->serdes_phy)) { > ret = PTR_ERR(ethqos->serdes_phy); > -- > 2.39.2 >