From: Vladimir Oltean <olteanv@gmail.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Asmaa Mnebhi <asmaa@nvidia.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org, cai.huoqing@linux.dev,
brgl@bgdev.pl, chenhao288@hisilicon.com,
huangguangbin2@huawei.com,
David Thompson <davthompson@nvidia.com>
Subject: Re: [PATCH net v2 1/1] mlxbf_gige: Fix kernel panic at shutdown
Date: Tue, 13 Jun 2023 13:34:22 +0300 [thread overview]
Message-ID: <20230613103422.ppjeigcugva4gnks@skbuf> (raw)
In-Reply-To: <20230613101038.GY12152@unreal>
On Tue, Jun 13, 2023 at 01:10:38PM +0300, Leon Romanovsky wrote:
> On Tue, Jun 13, 2023 at 12:35:01PM +0300, Vladimir Oltean wrote:
> > Not really sure where you're aiming with your replies at this stage.
>
> My goal is to explain that "bus drivers may implement .shutdown()
> the same way as .remove()" is wrong implementation and expectation
> that all drivers will add "if (!priv) return ..." now is not viable.
I never said that all drivers should guard against that - just that it's
possible and that there is no mechanism to reject such a thing - which
is something you've incorrectly claimed.
The top-level platform bus for MMIO devices should not be do this, at
least as of now - so drivers written for just that should be fine.
However, platform devices created and probed by other drivers, such as
MFD, are worth double-checking.
next prev parent reply other threads:[~2023-06-13 10:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 14:03 [PATCH net v2 1/1] mlxbf_gige: Fix kernel panic at shutdown Asmaa Mnebhi
2023-06-08 23:25 ` Samudrala, Sridhar
2023-06-12 17:26 ` Jakub Kicinski
2023-06-11 18:11 ` Leon Romanovsky
2023-06-12 11:34 ` Maciej Fijalkowski
2023-06-12 11:59 ` Leon Romanovsky
2023-06-12 12:37 ` Vladimir Oltean
2023-06-12 13:17 ` Leon Romanovsky
2023-06-12 13:28 ` Vladimir Oltean
2023-06-12 13:38 ` Leon Romanovsky
2023-06-12 14:05 ` Vladimir Oltean
2023-06-13 7:19 ` Leon Romanovsky
2023-06-13 8:30 ` Vladimir Oltean
2023-06-13 9:09 ` Leon Romanovsky
2023-06-13 9:35 ` Vladimir Oltean
2023-06-13 10:10 ` Leon Romanovsky
2023-06-13 10:34 ` Vladimir Oltean [this message]
2023-06-13 11:28 ` Leon Romanovsky
2023-06-13 11:40 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230613103422.ppjeigcugva4gnks@skbuf \
--to=olteanv@gmail.com \
--cc=asmaa@nvidia.com \
--cc=brgl@bgdev.pl \
--cc=cai.huoqing@linux.dev \
--cc=chenhao288@hisilicon.com \
--cc=davem@davemloft.net \
--cc=davthompson@nvidia.com \
--cc=edumazet@google.com \
--cc=huangguangbin2@huawei.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).