From: Piotr Gardocki <piotrx.gardocki@intel.com>
To: netdev@vger.kernel.org
Cc: piotrx.gardocki@intel.com, intel-wired-lan@lists.osuosl.org,
przemyslaw.kitszel@intel.com, michal.swiatkowski@linux.intel.com,
pmenzel@molgen.mpg.de, kuba@kernel.org,
maciej.fijalkowski@intel.com, anthony.l.nguyen@intel.com,
simon.horman@corigine.com, aleksander.lobakin@intel.com
Subject: [PATCH net-next v2 3/3] ice: remove unnecessary check for old MAC == new MAC
Date: Tue, 13 Jun 2023 14:24:20 +0200 [thread overview]
Message-ID: <20230613122420.855486-4-piotrx.gardocki@intel.com> (raw)
In-Reply-To: <20230613122420.855486-1-piotrx.gardocki@intel.com>
The check has been moved to core. The ndo_set_mac_address callback
is not being called with new MAC address equal to the old one anymore.
Signed-off-by: Piotr Gardocki <piotrx.gardocki@intel.com>
---
drivers/net/ethernet/intel/ice/ice_main.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index caafb12d9cc7..f0ba896a3f46 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -5624,11 +5624,6 @@ static int ice_set_mac_address(struct net_device *netdev, void *pi)
if (!is_valid_ether_addr(mac))
return -EADDRNOTAVAIL;
- if (ether_addr_equal(netdev->dev_addr, mac)) {
- netdev_dbg(netdev, "already using mac %pM\n", mac);
- return 0;
- }
-
if (test_bit(ICE_DOWN, pf->state) ||
ice_is_reset_in_progress(pf->state)) {
netdev_err(netdev, "can't set mac %pM. device not ready\n",
--
2.34.1
next prev parent reply other threads:[~2023-06-13 12:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 12:24 [PATCH net-next v2 0/3] optimize procedure of changing MAC address on interface Piotr Gardocki
2023-06-13 12:24 ` [PATCH net-next v2 1/3] net: add check for current MAC address in dev_set_mac_address Piotr Gardocki
2023-06-13 13:10 ` Maciej Fijalkowski
2023-06-13 13:23 ` Paul Menzel
2023-06-13 13:25 ` Fijalkowski, Maciej
2023-06-20 7:16 ` Gal Pressman
2023-06-20 10:29 ` Piotr Gardocki
2023-06-20 10:42 ` Gal Pressman
2023-06-20 15:59 ` Jakub Kicinski
2023-06-20 16:23 ` Piotr Gardocki
2023-06-20 16:25 ` Gal Pressman
2023-06-13 12:24 ` [PATCH net-next v2 2/3] i40e: remove unnecessary check for old MAC == new MAC Piotr Gardocki
2023-06-13 13:11 ` Maciej Fijalkowski
2023-06-13 12:24 ` Piotr Gardocki [this message]
2023-06-13 13:13 ` [PATCH net-next v2 3/3] ice: " Maciej Fijalkowski
2023-06-13 14:02 ` Przemek Kitszel
2023-06-13 15:10 ` [Intel-wired-lan] " Przemek Kitszel
2023-06-13 15:16 ` Piotr Gardocki
2023-06-13 15:24 ` Przemek Kitszel
2023-06-13 15:32 ` Piotr Gardocki
2023-06-13 18:24 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230613122420.855486-4-piotrx.gardocki@intel.com \
--to=piotrx.gardocki@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=przemyslaw.kitszel@intel.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).