Re: [PATCH 02/26] dt-bindings: phy: describe the Qualcomm SGMII PHY

Krzysztof Kozlowski
2023-06-14T07:13:42Z

On 12/06/2023 11:23, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Describe the SGMII/SerDes PHY present on the sa8775p platforms.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

> +properties:
> + compatible:
> + const: qcom,sa8775p-dwmac-sgmii-phy
> +
> + reg:
> + items:
> + - description: serdes
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + const: sgmi_ref
> +
> + "#phy-cells":
> + const: 0
> +
> +additionalProperties: false

Please put it after required: block.

> +
> +required:
> + - compatible
> + - reg
> + - "#phy-cells"
> + - clocks
> + - clock-names
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/qcom,sa8775p-gcc.h>
> + serdes_phy: phy@8901000 {
> + compatible = "qcom,sa8775p-dwmac-sgmii-phy";
> + reg = <0x08901000 0xe10>;
> + clocks = <&gcc GCC_SGMI_CLKREF_EN>;
> + clock-names = "sgmi_ref";
> + #phy-cells = <0>;
> + status = "disabled";

Drop the status.

With above:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

> + };

Best regards,
Krzysztof