From: Stephen Hemminger <stephen@networkplumber.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org,
Pavan Kumar Linga <pavan.kumar.linga@intel.com>,
emil.s.tantilov@intel.com, jesse.brandeburg@intel.com,
sridhar.samudrala@intel.com, shiraz.saleem@intel.com,
sindhu.devale@intel.com, willemb@google.com, decot@google.com,
andrew@lunn.ch, leon@kernel.org, mst@redhat.com,
simon.horman@corigine.com, shannon.nelson@amd.com,
Alan Brady <alan.brady@intel.com>,
Joshua Hay <joshua.a.hay@intel.com>,
Madhu Chittim <madhu.chittim@intel.com>,
Phani Burra <phani.r.burra@intel.com>,
Shailendra Bhatnagar <shailendra.bhatnagar@intel.com>
Subject: Re: [PATCH net-next v2 05/15] idpf: add create vport and netdev configuration
Date: Wed, 14 Jun 2023 11:21:44 -0700 [thread overview]
Message-ID: <20230614112144.55d2fdf9@hermes.local> (raw)
In-Reply-To: <20230614171428.1504179-6-anthony.l.nguyen@intel.com>
On Wed, 14 Jun 2023 10:14:18 -0700
Tony Nguyen <anthony.l.nguyen@intel.com> wrote:
> + /* TX */
> + int num_txq;
> + int num_complq;
> + /* It makes more sense for descriptor count to be part of only idpf
> + * queue structure. But when user changes the count via ethtool, driver
> + * has to store that value somewhere other than queue structure as the
> + * queues will be freed and allocated again.
> + */
> + int txq_desc_count;
> + int complq_desc_count;
> + int num_txq_grp;
> + u32 txq_model;
> +
> + /* RX */
> + int num_rxq;
> + int num_bufq;
> + int rxq_desc_count;
If value can never be negative, you can avoid future errors by using
an unsigned type. Ideally to save space use u32 or u16.
next prev parent reply other threads:[~2023-06-14 18:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 17:14 [PATCH net-next v2 00/15][pull request] Introduce Intel IDPF driver Tony Nguyen
2023-06-14 17:14 ` [PATCH net-next v2 01/15] virtchnl: add virtchnl version 2 ops Tony Nguyen
2023-06-14 17:14 ` [PATCH net-next v2 02/15] idpf: add module register and probe functionality Tony Nguyen
2023-06-14 17:14 ` [PATCH net-next v2 03/15] idpf: add controlq init and reset checks Tony Nguyen
2023-06-17 6:42 ` Jakub Kicinski
2023-06-21 19:05 ` Linga, Pavan Kumar
2023-06-21 19:14 ` Jakub Kicinski
2023-06-21 19:43 ` Simon Horman
2023-06-14 17:14 ` [PATCH net-next v2 04/15] idpf: add core init and interrupt request Tony Nguyen
2023-06-17 6:50 ` Jakub Kicinski
2023-06-21 19:07 ` Linga, Pavan Kumar
2023-06-14 17:14 ` [PATCH net-next v2 05/15] idpf: add create vport and netdev configuration Tony Nguyen
2023-06-14 18:21 ` Stephen Hemminger [this message]
2023-06-15 0:12 ` Linga, Pavan Kumar
2023-06-14 17:14 ` [PATCH net-next v2 06/15] idpf: continue expanding init task Tony Nguyen
2023-06-14 17:14 ` [PATCH net-next v2 07/15] idpf: configure resources for TX queues Tony Nguyen
2023-06-14 17:14 ` [PATCH net-next v2 08/15] idpf: configure resources for RX queues Tony Nguyen
2023-06-14 17:14 ` [PATCH net-next v2 09/15] idpf: initialize interrupts and enable vport Tony Nguyen
2023-06-14 17:14 ` [PATCH net-next v2 10/15] idpf: add splitq start_xmit Tony Nguyen
2023-06-14 17:14 ` [PATCH net-next v2 11/15] idpf: add TX splitq napi poll support Tony Nguyen
2023-06-14 17:14 ` [PATCH net-next v2 12/15] idpf: add RX " Tony Nguyen
2023-06-17 6:55 ` Jakub Kicinski
2023-06-21 19:07 ` Linga, Pavan Kumar
2023-06-17 7:01 ` Jakub Kicinski
2023-06-21 19:09 ` Linga, Pavan Kumar
2023-06-21 19:21 ` Jakub Kicinski
2023-06-14 17:14 ` [PATCH net-next v2 13/15] idpf: add singleq start_xmit and napi poll Tony Nguyen
2023-06-14 17:14 ` [PATCH net-next v2 14/15] idpf: add ethtool callbacks Tony Nguyen
2023-06-14 17:14 ` [PATCH net-next v2 15/15] idpf: configure SRIOV and add other ndo_ops Tony Nguyen
-- strict thread matches above, loose matches on Subject: below --
2023-04-11 1:13 [PATCH net-next v2 00/15] Introduce Intel IDPF driver Pavan Kumar Linga
2023-04-11 1:13 ` [PATCH net-next v2 05/15] idpf: add create vport and netdev configuration Pavan Kumar Linga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230614112144.55d2fdf9@hermes.local \
--to=stephen@networkplumber.org \
--cc=alan.brady@intel.com \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=decot@google.com \
--cc=edumazet@google.com \
--cc=emil.s.tantilov@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=joshua.a.hay@intel.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=madhu.chittim@intel.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.kumar.linga@intel.com \
--cc=phani.r.burra@intel.com \
--cc=shailendra.bhatnagar@intel.com \
--cc=shannon.nelson@amd.com \
--cc=shiraz.saleem@intel.com \
--cc=simon.horman@corigine.com \
--cc=sindhu.devale@intel.com \
--cc=sridhar.samudrala@intel.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).