From: Jakub Kicinski <kuba@kernel.org>
To: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>
Cc: Jiasheng Jiang <jiasheng@iscas.ac.cn>,
vburru@marvell.com, aayarekar@marvell.com, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, sburla@marvell.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] octeon_ep: Add missing check for ioremap
Date: Wed, 14 Jun 2023 12:51:04 -0700 [thread overview]
Message-ID: <20230614125104.0d29b00c@kernel.org> (raw)
In-Reply-To: <CAH-L+nM3kPWxyLn_iO7ktmd5E+URG=EfPW2FWnd6fxdSVdb7Hg@mail.gmail.com>
On Wed, 14 Jun 2023 11:33:17 +0530 Kalesh Anakkur Purayil wrote:
> > kfree(oct->conf);
> > return -1;
> >
> [Kalesh]: fix to return -ENOMEM instead of -1.
The author is not touching the return code, seems unrelated.
next prev parent reply other threads:[~2023-06-14 19:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 3:23 [PATCH] octeon_ep: Add missing check for ioremap Jiasheng Jiang
2023-06-14 6:03 ` Kalesh Anakkur Purayil
2023-06-14 19:51 ` Jakub Kicinski [this message]
2023-06-14 19:53 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2023-06-15 3:24 Jiasheng Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230614125104.0d29b00c@kernel.org \
--to=kuba@kernel.org \
--cc=aayarekar@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiasheng@iscas.ac.cn \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sburla@marvell.com \
--cc=vburru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).